Fix more <a> color #91179
Merged
Fix more <a> color #91179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
commented
Nov 24, 2021
| goto: file://|DOC_PATH|/test_docs/struct.HeavilyDocumentedStruct.html | ||
|
|
||
| // This is needed to ensure that the text color is computed. | ||
| show-text: true |
There was a problem hiding this comment.
This was originally missing, meaning that the colors weren't computed. I'll add a failure in browser-ui-test directly.
GuillaumeGomez
commented
Nov 24, 2021
| assert-css: (".srclink", {"color": "rgba(0, 0, 0, 0)"}) | ||
| assert-css: ("#toggle-all-docs", {"color": "rgb(0, 0, 0)"}) | ||
| assert-css: (".fqn .in-band a:nth-of-type(1)", {"color": "rgb(0, 0, 0)"}) | ||
| assert-css: (".fqn .in-band a:nth-of-type(2)", {"color": "rgb(173, 68, 142)"}) |
There was a problem hiding this comment.
Therefore this color was updated as well (it's for a struct so not black contrary to the other members of the import).
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
a-color
branch
from
3b8f5a8
to
0ba92fe
Compare
|
Thanks for the fix! @bors r+ |
|
📌 Commit 0ba92fe has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 24, 2021
Fix more <a> color Fixes rust-lang#91175. Another bug I saw is:  I fixed it as well. r? `@jsha`
|
Per #91196 it looks like we also need a rule for |
|
This PR is already in a rollup, so a separate PR is probably best. |
|
Also please open an issue so we can keep track of things more easily. |
There's already #91196...? |
|
Indeed... Sorry, tired. Please ignore my comment. |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 24, 2021
Fix more <a> color Fixes rust-lang#91175. Another bug I saw is:  I fixed it as well. r? `@jsha`
This was referenced Nov 24, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 24, 2021
…laumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#89542 (Partially stabilize `duration_consts_2`) - rust-lang#90044 (Restrict aarch64 outline atomics to glibc for now.) - rust-lang#90420 (Create rustdoc_internals feature gate) - rust-lang#91075 (Reduce prominence of item-infos) - rust-lang#91151 (Fix test in std::process on android) - rust-lang#91179 (Fix more <a> color) - rust-lang#91199 (rustdoc: Add test for mixing doc comments and attrs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
It turns out |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 25, 2021
…ci, r=jsha Improve rustdoc-gui CI As commented [here](rust-lang#91179 (comment)): When the text isn't displayed, the color returned by puppeteer is always `rgba(0,0,0,0)`, which is definitely not the right value. To prevent this error from happening again, `browser-ui-test` will now fail if a CSS color check is run when the text isn't displayed. Either this PR or rust-lang#91179 is merged first, they'll conflict because I made changes to the same test file. cc `@jyn514` r? `@jsha`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 25, 2021
…ci, r=jsha Improve rustdoc-gui CI As commented [here](rust-lang#91179 (comment)): When the text isn't displayed, the color returned by puppeteer is always `rgba(0,0,0,0)`, which is definitely not the right value. To prevent this error from happening again, `browser-ui-test` will now fail if a CSS color check is run when the text isn't displayed. Either this PR or rust-lang#91179 is merged first, they'll conflict because I made changes to the same test file. cc ``@jyn514`` r? ``@jsha``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 25, 2021
…ci, r=jsha Improve rustdoc-gui CI As commented [here](rust-lang#91179 (comment)): When the text isn't displayed, the color returned by puppeteer is always `rgba(0,0,0,0)`, which is definitely not the right value. To prevent this error from happening again, `browser-ui-test` will now fail if a CSS color check is run when the text isn't displayed. Either this PR or rust-lang#91179 is merged first, they'll conflict because I made changes to the same test file. cc ```@jyn514``` r? ```@jsha```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 26, 2021
…, r=jsha Improve rustdoc-gui CI As commented [here](rust-lang#91179 (comment)): When the text isn't displayed, the color returned by puppeteer is always `rgba(0,0,0,0)`, which is definitely not the right value. To prevent this error from happening again, `browser-ui-test` will now fail if a CSS color check is run when the text isn't displayed. Either this PR or rust-lang#91179 is merged first, they'll conflict because I made changes to the same test file. cc `@jyn514` r? `@jsha`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91175.
Another bug I saw is:
I fixed it as well.
r? @jsha