Fix ICE in check_must_not_suspend_ty()
#91367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
apiraino
added
the
T-compiler
nagisa
reviewed
Dec 5, 2021
FabianWolff
force-pushed
the
issue-91334-ice
branch
from
6c3e6fe
to
a8daff2
Compare
|
@bors r+ |
|
📌 Commit a8daff2 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 6, 2021
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#91367 (Fix ICE in `check_must_not_suspend_ty()`) - rust-lang#91391 (Simplify --no-headless option for rustdoc-gui tester) - rust-lang#91537 (compiler/rustc_target: make m68k-unknown-linux-gnu use the gnu base) - rust-lang#91554 (Update doc about code block edition attributes) - rust-lang#91563 (Bump download-ci-llvm-stamp for LLD inclusion) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91334. I have also used
TyS::tuple_fields()(instead of theSubstsRefdirectly) to get the tuple fields, because that's what the documentation says, although it doesn't seem to make a difference in practice (this is not what fixed the ICE).