Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate inline const pat early and report error if too generic #91570

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

nbdd0121
Copy link
Contributor

@nbdd0121 nbdd0121 commented Dec 5, 2021

Fix #90150

@rustbot label: T-compiler F-inline_const

@rustbot rustbot added F-inline_const Inline constants (aka: const blocks, const expressions, anonymous constants) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 5, 2021
@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 5, 2021
@petrochenkov
Copy link
Contributor

r? @RalfJung for review or reassignment

@RalfJung
Copy link
Member

RalfJung commented Dec 6, 2021

Pattern matching is completely out of my realm, I am afraid.
Cc @rust-lang/wg-const-eval
r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned RalfJung Dec 6, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Dec 7, 2021

@bors r+ rollup

Good idea! The eager eval makes sense as we never handle generics in patterns anyway.

@bors
Copy link
Contributor

bors commented Dec 7, 2021

📌 Commit 2a95958 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 8, 2021
Evaluate inline const pat early and report error if too generic

Fix rust-lang#90150

`@rustbot` label: T-compiler F-inline_const
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 8, 2021
Evaluate inline const pat early and report error if too generic

Fix rust-lang#90150

``@rustbot`` label: T-compiler F-inline_const
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 8, 2021
Evaluate inline const pat early and report error if too generic

Fix rust-lang#90150

```@rustbot``` label: T-compiler F-inline_const
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 8, 2021
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#90709 (Only shown relevant type params in E0283 label)
 - rust-lang#91551 (Allow for failure of subst_normalize_erasing_regions in const_eval)
 - rust-lang#91570 (Evaluate inline const pat early and report error if too generic)
 - rust-lang#91571 (Remove unneeded access to pretty printer's `s` field in favor of deref)
 - rust-lang#91610 (Link to rustdoc_json_types docs instead of rustdoc-json RFC)
 - rust-lang#91619 (Update cargo)
 - rust-lang#91630 (Add missing whitespace before disabled HTML attribute)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 67c5832 into rust-lang:master Dec 8, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 8, 2021
@nbdd0121 nbdd0121 deleted the const_typeck branch January 14, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-inline_const Inline constants (aka: const blocks, const expressions, anonymous constants) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE on inline const pattern using const generic parameter
7 participants