-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core::ops::unsize: improve docs for DispatchFromDyn #91587
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrc
added
A-DSTs
Area: Dynamically-sized types (DSTs)
A-docs
Area: documentation for any part of the project, including the compiler, standard library, and tools
F-dispatch_from_dyn
`#![feature(dispatch_from_dyn)]`
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Dec 6, 2021
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 6, 2021
This comment has been minimized.
This comment has been minimized.
nrc
force-pushed
the
dispatchfromdyn-docs
branch
from
December 6, 2021 11:31
c8d275d
to
b9f7761
Compare
The WF-ness properties are enforced in https://github.com/rust-lang/rust/blob/master/compiler/rustc_typeck/src/coherence/builtin.rs#L121 |
Signed-off-by: Nick Cameron <nrc@ncameron.org>
nrc
force-pushed
the
dispatchfromdyn-docs
branch
from
December 7, 2021 12:27
b9f7761
to
b3573c5
Compare
ping @rust-lang/libs could I get a review please? Docs changes only. |
📌 Commit b3573c5 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 4, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 4, 2022
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#91587 (core::ops::unsize: improve docs for DispatchFromDyn) - rust-lang#91907 (Allow `_` as the length of array types and repeat expressions) - rust-lang#92515 (RustWrapper: adapt for an LLVM API change) - rust-lang#92516 (Do not use deprecated -Zsymbol-mangling-version in bootstrap) - rust-lang#92530 (Move `contains` method of Option and Result lower in docs) - rust-lang#92546 (Update books) - rust-lang#92551 (rename StackPopClean::None to Root) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-docs
Area: documentation for any part of the project, including the compiler, standard library, and tools
A-DSTs
Area: Dynamically-sized types (DSTs)
F-dispatch_from_dyn
`#![feature(dispatch_from_dyn)]`
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs-only PR, improves documentation for DispatchFromDyn.