-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debuginfo: Recursive types and some trait object pointer support #9168
Conversation
This looks good to me. Let's just see if we can avoid using @fn, since their future is in doubt. |
I've tried that but we can't use an All that being said, I think this will need a refactoring within the next few weeks anyway---so it might be OK to leave the |
It's possible to specific built-in trait bounds on a fn's environment with a colon: i.e. However, it still won't work, since |
Very well. Fix up the nits and this is good to go! |
Also fixed nasty bug caused by calling LLVMDIBuilderCreateStructType() with a null pointer where an empty array was expected (which would trigger an unintelligable assertion somewhere down the line).
OK, I fixed the style issues and did a rebase. @huonw Thanks for hint |
Sorry about that. Retry please... |
Heh, every time. We should write a script that generates that list from the header file or something. |
Yeah |
This pull request finally adds support for recursive type definitions and provides a stub implementation for object pointers.
This pull request finally adds support for recursive type definitions and provides a stub implementation for object pointers.