Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove in_band_lifetimes from rustc_trait_selection #91889

Conversation

LegionMammal978
Copy link
Contributor

See #91867 for more information.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 14, 2021
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nagisa (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 14, 2021
@workingjubilee
Copy link
Member

Please give this one a different commit message and PR title.

@LegionMammal978 LegionMammal978 force-pushed the less-inband-trait_selection branch from 1a0ce09 to 8bf4964 Compare December 14, 2021 15:12
@LegionMammal978 LegionMammal978 changed the title Remove in_band_lifetimes from rustc_const_eval Remove in_band_lifetimes from rustc_trait_selection Dec 14, 2021
@jackh726
Copy link
Member

Even though this was opened before #91904, that one is already r+ed, so going to close this. Sorry!

@jackh726 jackh726 closed this Dec 14, 2021
@LegionMammal978 LegionMammal978 deleted the less-inband-trait_selection branch December 14, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants