miri: lift restriction on extern types being the only field in a struct #91910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
rust-highfive
added
the
S-waiting-on-review
RalfJung
reviewed
Dec 15, 2021
| fn main() { | ||
| assert_eq!(A_REF.as_slice(), &[5, 6, 7]); | ||
| // Check that interpreter and code generation agree about the position of the tail field. | ||
| assert_eq!(A_TAIL_OFFSET, tail_offset(A_REF)); |
There was a problem hiding this comment.
Nice test. :)
I wonder if there are corner cases that make it more challenging, like newtype-wrapping Opaque in a repr(align) type to ensure it has alignment larger than usize?
tmiasko
force-pushed
the
miri-extern-type
branch
from
d26a329
to
7b65bb9
Compare
RalfJung
reviewed
Dec 15, 2021
RalfJung
reviewed
Dec 15, 2021
RalfJung
reviewed
Dec 15, 2021
tmiasko
force-pushed
the
miri-extern-type
branch
from
7b65bb9
to
fd47d24
Compare
|
Thanks! |
|
📌 Commit fd47d24 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 17, 2021
miri: lift restriction on extern types being the only field in a struct Fixes rust-lang#91827. r? `@RalfJung`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 17, 2021
miri: lift restriction on extern types being the only field in a struct Fixes rust-lang#91827. r? ``@RalfJung``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 17, 2021
miri: lift restriction on extern types being the only field in a struct Fixes rust-lang#91827. r? ```@RalfJung```
This was referenced Dec 17, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 18, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#87901 (Fix suggestion of additional `pub` when using `pub pub fn ...`) - rust-lang#89090 (Lint bare traits in AstConv.) - rust-lang#91818 (Show the unused type for `unused_results` lint) - rust-lang#91910 (miri: lift restriction on extern types being the only field in a struct) - rust-lang#91928 (Constify (most) `Option` methods) - rust-lang#91975 (Move generator check earlier in inlining.) - rust-lang#92016 (builtin_macros: allow external consumers for AsmArgs parsing) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91827.
r? @RalfJung