-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #91914
Rollup of 7 pull requests #91914
Commits on Dec 13, 2021
-
When
.await
is called on a non-Future
expression, suggest removalKeep track of the origin of a `T: Future` obligation when caused by an `.await` expression. Address rust-lang#66731.
Configuration menu - View commit details
-
Copy full SHA for 7227a87 - Browse repository at this point
Copy the full SHA 7227a87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75b6275 - Browse repository at this point
Copy the full SHA 75b6275View commit details -
Configuration menu - View commit details
-
Copy full SHA for caf0c1b - Browse repository at this point
Copy the full SHA caf0c1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 81a3b90 - Browse repository at this point
Copy the full SHA 81a3b90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79749d6 - Browse repository at this point
Copy the full SHA 79749d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f2b1c0 - Browse repository at this point
Copy the full SHA 4f2b1c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d45e030 - Browse repository at this point
Copy the full SHA d45e030View commit details -
Keep info on pre-desugaring expression for better "incorrect
.await
……" suggestion Keep the `HirId` of `.await`ed expressions so in the case of a `fn` call on on a sync `fn`, we can suggest maybe turning it into an `async fn`.
Configuration menu - View commit details
-
Copy full SHA for f640438 - Browse repository at this point
Copy the full SHA f640438View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8888d0d - Browse repository at this point
Copy the full SHA 8888d0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b825b0f - Browse repository at this point
Copy the full SHA b825b0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ecb141 - Browse repository at this point
Copy the full SHA 9ecb141View commit details -
The spans no longer overlap, so we no longer need to specialize the output depending on whether they would.
Configuration menu - View commit details
-
Copy full SHA for d59f74a - Browse repository at this point
Copy the full SHA d59f74aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64dea33 - Browse repository at this point
Copy the full SHA 64dea33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a7f2d5 - Browse repository at this point
Copy the full SHA 1a7f2d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64f88e8 - Browse repository at this point
Copy the full SHA 64f88e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2fc84f - Browse repository at this point
Copy the full SHA f2fc84fView commit details -
Revert "Set MACOSX_DEPLOYMENT_TARGET env var to default for linking i…
…f not set." This reverts commit b376f56, which is the main part of rust-lang#90499, because it turns out that this causes a good amount of breakage in crates relying on the old behavior. Fixes rust-lang#91372.
Configuration menu - View commit details
-
Copy full SHA for 3011154 - Browse repository at this point
Copy the full SHA 3011154View commit details
Commits on Dec 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ae21dd0 - Browse repository at this point
Copy the full SHA ae21dd0View commit details -
Remove
in_band_lifetimes
fromrustc_trait_selection
Sylvan Bowdler committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 1ea756b - Browse repository at this point
Copy the full SHA 1ea756bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90aa8fb - Browse repository at this point
Copy the full SHA 90aa8fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97e844a - Browse repository at this point
Copy the full SHA 97e844aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a586e7d - Browse repository at this point
Copy the full SHA a586e7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c771970 - Browse repository at this point
Copy the full SHA c771970View commit details -
Rollup merge of rust-lang#90939 - estebank:wg-af-polish, r=tmandry
Tweak errors coming from `for`-loop, `?` and `.await` desugaring * Suggest removal of `.await` on non-`Future` expression * Keep track of obligations introduced by desugaring * Remove span pointing at method for obligation errors coming from desugaring * Point at called local sync `fn` and suggest making it `async` ``` error[E0277]: `()` is not a future --> $DIR/unnecessary-await.rs:9:10 | LL | boo().await; | -----^^^^^^ `()` is not a future | | | this call returns `()` | = help: the trait `Future` is not implemented for `()` help: do not `.await` the expression | LL - boo().await; LL + boo(); | help: alternatively, consider making `fn boo` asynchronous | LL | async fn boo () {} | +++++ ``` Fix rust-lang#66731.
Configuration menu - View commit details
-
Copy full SHA for 2666841 - Browse repository at this point
Copy the full SHA 2666841View commit details -
Rollup merge of rust-lang#91870 - rusticstuff:macosx_min_version_reve…
…rt, r=Mark-Simulacrum Revert setting a default for the MACOSX_DEPLOYMENT_TARGET env var for linking This reverts commit b376f56, which is the main part of rust-lang#90499, because it turns out that this causes a good amount of breakage in crates relying on the old behavior. In particular `winit`, `coreaudio` and crates that depend on them are affected. Fixes rust-lang#91372. Background: Before rust-lang#90499 the behavior was the following: If MACOSX_DEPLOYMENT_TARGET is not set, we pass the minimum supported OS version to LLVM but not to the linker. The linker default depends on the Xcode version and the version of the OS it is running on. That caused one known problem in libcurl with the most recent Xcode versions. rust-lang#90499 passed the minumum supported version (10.7 for Macos x86-64) to the linker instead. This has shown to be problematic because some crates such as winit, coreaudio implicitly expect a newer minimum OS version. The libcurl issue has been fixed independently (see alexcrichton/curl-rust#417), so a revert should not really be problematic. Eventually we should probably mimic clang's behavior and fall back to the default of the currently configured Macos SDK for both the LLVM min os target version and MACOSX_DEPLOYMENT_TARGET for linking. That would entail looking at the `Version` property of the `SDKSettings.json` in the currently configured SDK.
Configuration menu - View commit details
-
Copy full SHA for 421c5f1 - Browse repository at this point
Copy the full SHA 421c5f1View commit details -
Rollup merge of rust-lang#91880 - matthiaskrgr:clippy_perf_dec, r=jyn514
fix clippy::single_char_pattern perf findings
Configuration menu - View commit details
-
Copy full SHA for ed84782 - Browse repository at this point
Copy the full SHA ed84782View commit details -
Rollup merge of rust-lang#91882 - Patrick-Poitras:remove-in-band-life…
…times-from-rustc-typeck, r=jackh726 Remove `in_band_lifetimes` from `rustc_typeck` Joining in on the effort to remove the `in_band_lifetimes` features, as described in issue rust-lang#91867.
Configuration menu - View commit details
-
Copy full SHA for 20106a3 - Browse repository at this point
Copy the full SHA 20106a3View commit details -
Rollup merge of rust-lang#91904 - SylvanB:remove_in_band_lifetimes_ru…
…stc_trait_selection, r=petrochenkov Remove `in_band_lifetimes` from `rustc_trait_selection` Another one for rust-lang#91867
Configuration menu - View commit details
-
Copy full SHA for 087f3b7 - Browse repository at this point
Copy the full SHA 087f3b7View commit details -
Rollup merge of rust-lang#91906 - anuvratsingh:remove_in_band_lifetim…
…es_library_proc_macro, r=petrochenkov Removed `in_band_lifetimes` from `library\proc_macro` Issue [rust-lang#91867](rust-lang#91867) This is my first try, I followed the instructions given. Fixed all the errors that were thrown while compiling. Compiled with stage 0,1, and 2 all of them compiled successfully.
Configuration menu - View commit details
-
Copy full SHA for 74a8661 - Browse repository at this point
Copy the full SHA 74a8661View commit details -
Rollup merge of rust-lang#91909 - lnicola:rust-analyzer-2021-12-14, r…
…=lnicola ⬆️ rust-analyzer r? ``@ghost``
Configuration menu - View commit details
-
Copy full SHA for d910cc1 - Browse repository at this point
Copy the full SHA d910cc1View commit details