Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Forbid unused_lifetimes lint for Crater run #92413

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] Forbid unused_lifetimes lint for Crater run #92413

wants to merge 1 commit into from

Conversation

Aaron1011
Copy link
Member

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 29, 2021
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 29, 2021
@Aaron1011
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Dec 29, 2021

⌛ Trying commit 240476a9a2089ebfcd39f752ddb6dfb485078c40 with merge df6b2a614694815ea299bbd35da94f863e9820f5...

@bors
Copy link
Contributor

bors commented Dec 29, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Aaron1011 Aaron1011 force-pushed the crater-unused-lifetimes branch from 240476a to 38ae19b Compare December 29, 2021 22:28
@Aaron1011
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Dec 29, 2021

⌛ Trying commit 38ae19bc1731cd15c3fa3e6c9c1a4ad722a049bb with merge 80898e5127067c96aa73ad33f7ff29460aa0ded2...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Dec 30, 2021

💔 Test failed - checks-actions

@Aaron1011 Aaron1011 force-pushed the crater-unused-lifetimes branch from 38ae19b to 80bef08 Compare December 30, 2021 03:07
@Aaron1011
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Dec 30, 2021

⌛ Trying commit 80bef08c8262abb75a4e4a05833d75bfe87d23bc with merge 1ecd5593dc72952fc2259078e12bfca1c351902b...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Dec 30, 2021

💔 Test failed - checks-actions

Aaron1011 added a commit to Aaron1011/cargo that referenced this pull request Dec 30, 2021
@Aaron1011
Remove unused lifetimes
c8761d4 
This is blocking the Crater run in rust-lang/rust#92413,
since a 'try' build needs to build Cargo.
@Aaron1011 Aaron1011 mentioned this pull request Dec 30, 2021
Merged
bors added a commit to rust-lang/cargo that referenced this pull request Dec 30, 2021
@bors
Auto merge of #10238 - Aaron1011:remove-lifetimes, r=joshtriplett
9af67cf 
Remove unused lifetimes

This is blocking the Crater run in rust-lang/rust#92413,
since a 'try' build needs to build Cargo.
@joshtriplett
Copy link
Member

@Aaron1011 Cargo has been fixed now to no longer trigger unused_lifetimes, so we should give this another shot.

@Aaron1011 Aaron1011 force-pushed the crater-unused-lifetimes branch from 80bef08 to 7fd7637 Compare January 4, 2022 18:35
@Aaron1011
Copy link
Member Author

@bors try

@craterbot
Copy link
Collaborator

🛠️ Experiment pr-92413 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-92413 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚨 Experiment pr-92413 has encountered an error: docker is not running
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Mark-Simulacrum
Copy link
Member

@craterbot retry

@craterbot
Copy link
Collaborator

🛠️ Experiment pr-92413 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-92413 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚨 Experiment pr-92413 has encountered an error: docker is not running
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Mark-Simulacrum
Copy link
Member

@craterbot retry

cc rust-lang/crater#590

@craterbot
Copy link
Collaborator

🛠️ Experiment pr-92413 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-92413 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚨 Experiment pr-92413 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

2 similar comments
@craterbot
Copy link
Collaborator

🚨 Experiment pr-92413 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚨 Experiment pr-92413 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jan 8, 2022
Merged
@Mark-Simulacrum
Copy link
Member

@craterbot retry

Underlying failure should be addressed by rust-lang/crater#596, but it's an intermittent failure.

@craterbot
Copy link
Collaborator

🛠️ Experiment pr-92413 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-92413 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

bors added a commit to rust-lang/crater that referenced this pull request Jan 8, 2022
@bors
Auto merge of #596 - Mark-Simulacrum:retry-timeout, r=Mark-Simulacrum
774de59 
Retry timeout

rust-lang/rust#92413 (comment) failed due to a request timeout, plausibly because of a parallel request (e.g., metrics) which locked out the database for long enough to cause a failure. This changes our retry logic to hopefully always retry timed out requests.

(It does not take the step we took with docker builds of unilaterally retrying *all* requests, but that may be a better path rather than trying to guess... for now this seems a more limited answer).
@craterbot
Copy link
Collaborator

🎉 Experiment pr-92413 is completed!
📊 3666 regressed and 7 fixed (204570 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 11, 2022
@Aaron1011 Aaron1011 mentioned this pull request Jan 14, 2022
Closed
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2022
@apiraino
Copy link
Contributor

@Aaron1011 I've tried getting the context for this PR, is waiting for a review the actual status? thanks :)

@jackh726 jackh726 added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2022
@JohnCSimon
Copy link
Member

@Aaron1011
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive

@JohnCSimon JohnCSimon closed this Nov 27, 2022
@rustbot rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidtwco davidtwco

Labels
S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.