Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing in pretty printed PatKind::Struct with no fields #92418

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Dec 29, 2021

Follow-up to #92238 fixing one of the FIXMEs.

macro_rules! repro {
    ($pat:pat) => {
        stringify!($pat)
    };
}

fn main() {
    println!("{}", repro!(Struct {}));
}

Before: Struct {  }
After: Struct {}

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 29, 2021
@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 29, 2021
@michaelwoerister
Copy link
Member

Looks good to me, thanks @dtolnay!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 3, 2022

📌 Commit 8d7cf1a has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 3, 2022
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#90102 (Remove `NullOp::Box`)
 - rust-lang#92011 (Use field span in `rustc_macros` when emitting decode call)
 - rust-lang#92402 (Suggest while let x = y when encountering while x = y)
 - rust-lang#92409 (Couple of libtest cleanups)
 - rust-lang#92418 (Fix spacing in pretty printed PatKind::Struct with no fields)
 - rust-lang#92444 (Consolidate Result's and Option's methods into fewer impl blocks)

Failed merges:

 - rust-lang#92483 (Stabilize `result_cloned` and `result_copied`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit df92119 into rust-lang:master Jan 3, 2022
@rustbot rustbot added this to the 1.59.0 milestone Jan 3, 2022
@dtolnay dtolnay deleted the emptystructpat branch January 3, 2022 18:52
@dtolnay dtolnay added the A-pretty Area: Pretty printing (incl. `-Z unpretty`). label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pretty Area: Pretty printing (incl. `-Z unpretty`). S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants