Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link impl items to corresponding trait items in late resolver. #92441

Merged
merged 6 commits into from
Jan 15, 2022

Conversation

cjgillot
Copy link
Contributor

Hygienically linking trait impl items to declarations in the trait can be done directly by the late resolver. In fact, it is already done to diagnose unknown items.

This PR uses this resolution work and stores the DefId of the trait item in the HIR. This avoids having to do this resolution manually later.

r? @matthewjasper
Related to #90639. The added trait_item_id field can be moved to ImplItemRef to be used directly by your PR.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 30, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 30, 2021
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 30, 2021
@bors
Copy link
Contributor

bors commented Dec 30, 2021

⌛ Trying commit 12d0895e72706e7e04f56436086e311b92004dee with merge 6eefde53ba5a5fd9bfcac37431aafdd496f5aa62...

@bors
Copy link
Contributor

bors commented Dec 30, 2021

☀️ Try build successful - checks-actions
Build commit: 6eefde53ba5a5fd9bfcac37431aafdd496f5aa62 (6eefde53ba5a5fd9bfcac37431aafdd496f5aa62)

@rust-timer
Copy link
Collaborator

Queued 6eefde53ba5a5fd9bfcac37431aafdd496f5aa62 with parent f8d4ee7, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6eefde53ba5a5fd9bfcac37431aafdd496f5aa62): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 30, 2021
@rust-log-analyzer

This comment has been minimized.

The `record_used` parameter changes the result, so we must pass the same
value for initial and module resolution.
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 15, 2022

📌 Commit 441c1a6 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2022
@bors
Copy link
Contributor

bors commented Jan 15, 2022

⌛ Testing commit 441c1a6 with merge ec4bcaa...

@bors
Copy link
Contributor

bors commented Jan 15, 2022

☀️ Test successful - checks-actions
Approved by: matthewjasper
Pushing ec4bcaa to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 15, 2022
@bors bors merged commit ec4bcaa into rust-lang:master Jan 15, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ec4bcaa): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants