Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store a Symbol instead of an Ident in VariantDef/FieldDef #92533

Merged
merged 1 commit into from
Jan 12, 2022

Commits on Jan 11, 2022

  1. Store a Symbol instead of an Ident in VariantDef/FieldDef

    The field is also renamed from `ident` to `name. In most cases,
    we don't actually need the `Span`. A new `ident` method is added
    to `VariantDef` and `FieldDef`, which constructs the full `Ident`
    using `tcx.def_ident_span()`. This method is used in the cases
    where we actually need an `Ident`.
    
    This makes incremental compilation properly track changes
    to the `Span`, without all of the invalidations caused by storing
    a `Span` directly via an `Ident`.
    Aaron1011 committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    450ef86 View commit details
    Browse the repository at this point in the history