-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destabilize RustcEncodable and RustcDecodable #92594
Changes from all commits
28aa986
cd60be9
634346d
c2167cc
77a0bfa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,7 +55,12 @@ pub use core::prelude::v1::{ | |
pub use core::prelude::v1::concat_bytes; | ||
|
||
// Do not `doc(inline)` these `doc(hidden)` items. | ||
#[stable(feature = "builtin_macro_prelude", since = "1.38.0")] | ||
#[unstable( | ||
feature = "rustc_encodable_decodable", | ||
issue = "none", | ||
soft, | ||
reason = "unstable implementation detail of the `rustc` compiler, do not use" | ||
)] | ||
#[allow(deprecated)] | ||
pub use core::prelude::v1::{RustcDecodable, RustcEncodable}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a similar reexport in |
||
|
||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,6 +1,6 @@ | ||||||
#[crate_type="lib"] | ||||||
|
||||||
// #13544 | ||||||
// FIXME: This should be replaced with some other derive macro | ||||||
#![feature(rustc_encodable_decodable)] | ||||||
#[crate_type="lib"] // Why is this an outer attribute? | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure what the comment is about, but this should be:
Suggested change
EDIT: Ah, I see, the attribute was pre-existing. Strange. Not sure what it's for then. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The comment is because the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, it's quite strange. I bet the |
||||||
|
||||||
extern crate rustc_serialize; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can likely swap this test out for derive(Debug) which'll make it simpler and drop the soft-deprecated feature use. |
||||||
|
||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can mark both macros as soft-unstable (see
macro bench
for an example), then the instability will be reported as a deny-by-default lint and won't break other crates depending on crates using these macros.