Suggest copying trait associated type bounds on lifetime error #92683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
jackh726
commented
Jan 9, 2022
| @@ -64,7 +64,7 @@ impl<'cx, 'tcx> NiceRegionError<'cx, 'tcx> { | |||
| .or_else(|| self.try_report_mismatched_static_lifetime()) | |||
| } | |||
|
|
|||
| pub fn regions(&self) -> Option<(Span, ty::Region<'tcx>, ty::Region<'tcx>)> { | |||
| pub(super) fn regions(&self) -> Option<(Span, ty::Region<'tcx>, ty::Region<'tcx>)> { | |||
| let origin = SubregionOrigin::from_obligation_cause(&cause, || { | ||
| infer::RelateParamBound(cause.span, sup_type, None) | ||
| }); | ||
| let origin = infer::RelateRegionParamBound(cause.span); |
There was a problem hiding this comment.
This and the one below are drive-by changes. These shouldn't ever be displayed anyways. But wanted to stop using from_obligation_cause (was potentially going a different direction for this PR).
| @@ -8,7 +8,7 @@ trait A<'a> { | |||
| // FIXME(generic_associated_types): Remove one of the below bounds | |||
| // https://github.com/rust-lang/rust/pull/90678#discussion_r744976085 | |||
| where | |||
| 'a: 'b, Self: 'a, Self: 'b; | |||
There was a problem hiding this comment.
This bound was required because of a bug that has since been fixed. FIXME still stands for the two remaining though.
nikomatsakis
approved these changes
Jan 10, 2022
|
r=me but I'll let @estebank do a review if he wants to |
|
☔ The latest upstream changes (presumably #92927) made this pull request unmergeable. Please resolve the merge conflicts. |
jackh726
force-pushed
the
issue-92033
branch
2 times, most recently
from
9bac686
to
814a62d
Compare
|
☔ The latest upstream changes (presumably #92007) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r=me after fixing rebase |
estebank
added
S-waiting-on-author
jackh726
force-pushed
the
issue-92033
branch
from
814a62d
to
3d19c8d
Compare
|
@bors r=estebank |
|
📌 Commit 3d19c8d has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 17, 2022
Suggest copying trait associated type bounds on lifetime error Closes rust-lang#92033 Kind of the most simple suggestion to make - we don't try to be fancy. Turns out, it's still pretty useful (the couple existing tests that trigger this error end up fixed - for this error - upon applying the fix). r? `@estebank` cc `@nikomatsakis`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 18, 2022
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#92683 (Suggest copying trait associated type bounds on lifetime error) - rust-lang#92933 (Deny mixing bin crate type with lib crate types) - rust-lang#92959 (Add more info and suggestions to use of #[test] on invalid items) - rust-lang#93024 (Do not ICE when inlining a function with un-satisfiable bounds) - rust-lang#93613 (Move `{core,std}::stream::Stream` to `{core,std}::async_iter::AsyncIterator`) - rust-lang#93634 (compiler: clippy::complexity fixes) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #92033
Kind of the most simple suggestion to make - we don't try to be fancy. Turns out, it's still pretty useful (the couple existing tests that trigger this error end up fixed - for this error - upon applying the fix).
r? @estebank
cc @nikomatsakis