Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for key="value" cfg arguments. #92835

Merged
merged 5 commits into from
Jan 22, 2022
Merged

Improve error message for key="value" cfg arguments. #92835

merged 5 commits into from
Jan 22, 2022

Commits on Jan 13, 2022

  1. Improve error message for cfg arguments. 

    This provides the user with a helpful error message in case a key="value"
message was specified but couldn't be parsed.
    @iwanders
    iwanders committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    90330b5 View commit details
    Browse the repository at this point in the history

  2. Update unit tests to accomodate for improved error.

    @iwanders
    iwanders committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    db56c6d View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2022

  1. Add unit test for cfg-arg without quotes.

    @iwanders
    iwanders committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    32be348 View commit details
    Browse the repository at this point in the history

  2. Limit scope of the hint about escaping.

    @iwanders
    iwanders committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    1531d26 View commit details
    Browse the repository at this point in the history

  3. Update unit tests to match more limited hint about escaping.

    @iwanders
    iwanders committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    af87248 View commit details
    Browse the repository at this point in the history