-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the updated Rust logo in rustdoc #92854
Conversation
Some changes occurred in HTML/CSS/JS. |
The favicon update is great! However, changing the format from cc @jsha |
@GuillaumeGomez interesting, I didn't know SVG was that slow! Do you have a citation for that? We are already using SVG for all of our icons. I doubt changing the logo as well would cause a noticeable performance problem. Are there specific platforms on which SVG is very slow? |
No, it's "browser knowledge": SVG aren't GPU accelerated for display. It doesn't change much at the end of the day though I guess... |
This page seems to suggest it's an issue for large, complex SVGs with many points: https://css-tricks.com/high-performance-svgs/. You can see in the diff here that the Rust logo is a nice, simple, tiny SVG. |
📌 Commit b8ef148 has been approved by |
Our webfonts probably have more overhead than this icon, both because they're in the critical path, and because this icon is less complicated than some of the glyphs they're rendering. |
I've been doing computers too long because I actually just thought "wow, that SVG has some beautiful source code." |
…Gomez Use the updated Rust logo in rustdoc This pull-request use the updated Rust logo from rust-lang/rust-artwork#9 and also change the logo format from PNG to SVG. | Before | After | | --- | --- | | ![Screenshot 2022-01-13 at 14-33-40 std - Rust](https://user-images.githubusercontent.com/3616612/149342697-7afe4c3e-2be5-444b-86f3-118712b4f7ae.png) | ![Screenshot 2022-01-13 at 14-33-15 std - Rust](https://user-images.githubusercontent.com/3616612/149342705-54ed27c6-0806-4c2d-baa1-4d65ed897e2b.png) | I also took the liberty to update the two PNG favicons with the SVG reducing their size by ~35% each. Fixes rust-lang#92831 r? `@jsha`
…Gomez Use the updated Rust logo in rustdoc This pull-request use the updated Rust logo from rust-lang/rust-artwork#9 and also change the logo format from PNG to SVG. | Before | After | | --- | --- | | ![Screenshot 2022-01-13 at 14-33-40 std - Rust](https://user-images.githubusercontent.com/3616612/149342697-7afe4c3e-2be5-444b-86f3-118712b4f7ae.png) | ![Screenshot 2022-01-13 at 14-33-15 std - Rust](https://user-images.githubusercontent.com/3616612/149342705-54ed27c6-0806-4c2d-baa1-4d65ed897e2b.png) | I also took the liberty to update the two PNG favicons with the SVG reducing their size by ~35% each. Fixes rust-lang#92831 r? ``@jsha``
…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#92045 (Don't fall back to crate-level opaque type definitions.) - rust-lang#92381 (Suggest `return`ing tail expressions in async functions) - rust-lang#92768 (Partially stabilize `maybe_uninit_extra`) - rust-lang#92810 (Deduplicate box deref and regular deref suggestions) - rust-lang#92818 (Update documentation for doc_cfg feature) - rust-lang#92840 (Fix some lints documentation) - rust-lang#92849 (Clippyup) - rust-lang#92854 (Use the updated Rust logo in rustdoc) - rust-lang#92864 (Fix a missing dot in the main item heading) Failed merges: - rust-lang#92838 (Clean up some links in RELEASES) r? `@ghost` `@rustbot` modify labels: rollup
This pull-request use the updated Rust logo from rust-lang/rust-artwork#9 and also change the logo format from PNG to SVG.
I also took the liberty to update the two PNG favicons with the SVG reducing their size by ~35% each.
Fixes #92831
r? @jsha