Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the updated Rust logo in rustdoc #92854

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Jan 13, 2022

This pull-request use the updated Rust logo from rust-lang/rust-artwork#9 and also change the logo format from PNG to SVG.

Before After
Screenshot 2022-01-13 at 14-33-40 std - Rust Screenshot 2022-01-13 at 14-33-15 std - Rust

I also took the liberty to update the two PNG favicons with the SVG reducing their size by ~35% each.

Fixes #92831

r? @jsha

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jan 13, 2022
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2022
@GuillaumeGomez
Copy link
Member

The favicon update is great! However, changing the format from png to svg will have an impact on the UI rendering because svg is slow.

cc @jsha

@jsha
Copy link
Contributor

jsha commented Jan 13, 2022

@GuillaumeGomez interesting, I didn't know SVG was that slow! Do you have a citation for that? We are already using SVG for all of our icons. I doubt changing the logo as well would cause a noticeable performance problem. Are there specific platforms on which SVG is very slow?

@GuillaumeGomez
Copy link
Member

No, it's "browser knowledge": SVG aren't GPU accelerated for display. It doesn't change much at the end of the day though I guess...

@jsha
Copy link
Contributor

jsha commented Jan 13, 2022

This page seems to suggest it's an issue for large, complex SVGs with many points: https://css-tricks.com/high-performance-svgs/. You can see in the diff here that the Rust logo is a nice, simple, tiny SVG.

@GuillaumeGomez
Copy link
Member

On that part we agree, what I meant was simply that svg was much slower than png. But in our case it's not really an issue I suppose.

Thanks again @Urgau!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jan 13, 2022

📌 Commit b8ef148 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2022
@notriddle
Copy link
Contributor

Our webfonts probably have more overhead than this icon, both because they're in the critical path, and because this icon is less complicated than some of the glyphs they're rendering.

@pierwill
Copy link
Member

You can see in the diff here that the Rust logo is a nice, simple, tiny SVG.

I've been doing computers too long because I actually just thought "wow, that SVG has some beautiful source code."

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 14, 2022
…Gomez

Use the updated Rust logo in rustdoc

This pull-request use the updated Rust logo from rust-lang/rust-artwork#9 and also change the logo format from PNG to SVG.

| Before | After |
| --- | --- |
| ![Screenshot 2022-01-13 at 14-33-40 std - Rust](https://user-images.githubusercontent.com/3616612/149342697-7afe4c3e-2be5-444b-86f3-118712b4f7ae.png) | ![Screenshot 2022-01-13 at 14-33-15 std - Rust](https://user-images.githubusercontent.com/3616612/149342705-54ed27c6-0806-4c2d-baa1-4d65ed897e2b.png) |

I also took the liberty to update the two PNG favicons with the SVG reducing their size by ~35% each.

Fixes rust-lang#92831

r? `@jsha`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 14, 2022
…Gomez

Use the updated Rust logo in rustdoc

This pull-request use the updated Rust logo from rust-lang/rust-artwork#9 and also change the logo format from PNG to SVG.

| Before | After |
| --- | --- |
| ![Screenshot 2022-01-13 at 14-33-40 std - Rust](https://user-images.githubusercontent.com/3616612/149342697-7afe4c3e-2be5-444b-86f3-118712b4f7ae.png) | ![Screenshot 2022-01-13 at 14-33-15 std - Rust](https://user-images.githubusercontent.com/3616612/149342705-54ed27c6-0806-4c2d-baa1-4d65ed897e2b.png) |

I also took the liberty to update the two PNG favicons with the SVG reducing their size by ~35% each.

Fixes rust-lang#92831

r? ``@jsha``
This was referenced Jan 14, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2022
…askrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#92045 (Don't fall back to crate-level opaque type definitions.)
 - rust-lang#92381 (Suggest `return`ing tail expressions in async functions)
 - rust-lang#92768 (Partially stabilize `maybe_uninit_extra`)
 - rust-lang#92810 (Deduplicate box deref and regular deref suggestions)
 - rust-lang#92818 (Update documentation for doc_cfg feature)
 - rust-lang#92840 (Fix some lints documentation)
 - rust-lang#92849 (Clippyup)
 - rust-lang#92854 (Use the updated Rust logo in rustdoc)
 - rust-lang#92864 (Fix a missing dot in the main item heading)

Failed merges:

 - rust-lang#92838 (Clean up some links in RELEASES)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dae3ef2 into rust-lang:master Jan 14, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 14, 2022
@Urgau Urgau deleted the better-rust-logo branch May 5, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc: use SVG form of Rust logo by default
8 participants