Make opt_const_param_of work in the presence of GenericArg::Infer
#92875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
BoxyUwU
added
the
A-const-generics
BoxyUwU
force-pushed
the
infer_arg_opt_const_param_of
branch
from
9d1bab4
to
b3d71d9
Compare
BoxyUwU
force-pushed
the
infer_arg_opt_const_param_of
branch
from
685f306
to
cc643ce
Compare
BoxyUwU
force-pushed
the
infer_arg_opt_const_param_of
branch
from
4cb6215
to
61c07a9
Compare
|
@bors r+ rollup |
|
📌 Commit 61c07a9 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 14, 2022
…f, r=lcnr Make `opt_const_param_of` work in the presence of `GenericArg::Infer` highly recommend viewing the first and second commits on their own rather than looking at file changes 🤣 Because we filtered args down to just const args we would ignore `GenericArg::Infer` which made us get a `arg_index` which was wrong by however many const `GenericArg::Infer` came previously [example](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=46dba6a53aca6333028a10908ef16e0b) of the [bugs](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=a8eebced26eefa4119fc2e7ae0c76de6) fixed. r? `@lcnr`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 14, 2022
…f, r=lcnr Make `opt_const_param_of` work in the presence of `GenericArg::Infer` highly recommend viewing the first and second commits on their own rather than looking at file changes 🤣 Because we filtered args down to just const args we would ignore `GenericArg::Infer` which made us get a `arg_index` which was wrong by however many const `GenericArg::Infer` came previously [example](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=46dba6a53aca6333028a10908ef16e0b) of the [bugs](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=a8eebced26eefa4119fc2e7ae0c76de6) fixed. r? ``@lcnr``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 15, 2022
…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#92191 (Prefer projection candidates instead of param_env candidates for Sized predicates) - rust-lang#92382 (Extend const_convert to rest of blanket core::convert impls) - rust-lang#92625 (Add `#[track_caller]` to `mirbug`) - rust-lang#92684 (Export `tcp::IntoIncoming`) - rust-lang#92743 (Use pre-interned symbols in a couple of places) - rust-lang#92838 (Clean up some links in RELEASES) - rust-lang#92868 (librustdoc: Address some clippy lints) - rust-lang#92875 (Make `opt_const_param_of` work in the presence of `GenericArg::Infer`) - rust-lang#92891 (Add myself to .mailmap) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
highly recommend viewing the first and second commits on their own rather than looking at file changes 🤣
Because we filtered args down to just const args we would ignore
GenericArg::Inferwhich made us get aarg_indexwhich was wrong by however many constGenericArg::Infercame previouslyexample of the bugs fixed.
r? @lcnr