Store a `Symbol` instead of an `Ident` in `AssocItem` #93095

Aaron1011 · 2022-01-19T21:44:53Z

This is the same idea as #92533, but for AssocItem instead
of VariantDef/FieldDef.

With this change, we no longer have any uses of
#[stable_hasher(project(...))]

rust-highfive · 2022-01-19T21:44:56Z

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

Aaron1011 · 2022-01-19T21:45:29Z

@bors try @rust-timer queue

rust-timer · 2022-01-19T21:45:30Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-01-19T21:45:37Z

⌛ Trying commit 188ad3a5ae520f5b6fec872277182baa8fbc88cd with merge f5ca923de1932f0ada0485a181f0ce7484cf8fe6...

This is the same idea as rust-lang#92533, but for `AssocItem` instead of `VariantDef`/`FieldDef`. With this change, we no longer have any uses of `#[stable_hasher(project(...))]`

rust-log-analyzer · 2022-01-19T22:47:39Z

The job dist-x86_64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Preparing cargo
[2022-01-19T22:20:00Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Check, run_kind=None, patch=None
[2022-01-19T22:20:00Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Debug, run_kind=None, patch=None
[2022-01-19T22:20:00Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Opt, run_kind=None, patch=None
[2022-01-19T22:20:00Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpqusa6t#cargo:0.29.0" "--release" "--lib" "--" "--skip-this-rustc"
[2022-01-19T22:20:00Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpXrxBU2#cargo:0.29.0" "--profile" "check" "--lib" "--" "--skip-this-rustc"
[2022-01-19T22:20:00Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpzdXoJx#cargo:0.29.0" "--lib" "--" "--skip-this-rustc"
[2022-01-19T22:21:24Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-01-19T22:21:24Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Check, run_kind=Some(Full), patch=None
[2022-01-19T22:21:24Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmp99kRzn#cargo:0.29.0" "--profile" "check" "--lib" "--" "--wrap-rustc-with" "eprintln"
[2022-01-19T22:21:38Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Check, run_kind=Some(IncrFull), patch=None
---
[2022-01-19T22:22:06Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-01-19T22:22:07Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Debug, run_kind=Some(Full), patch=None
[2022-01-19T22:22:07Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpvzS4ce#cargo:0.29.0" "--lib" "--" "--wrap-rustc-with" "eprintln"
[2022-01-19T22:22:36Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Debug, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:22:36Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpvzS4ce#cargo:0.29.0" "--lib" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpvzS4ce/incremental-state"
[2022-01-19T22:23:14Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Debug, run_kind=Some(IncrUnchanged), patch=None
[2022-01-19T22:23:14Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpvzS4ce#cargo:0.29.0" "--lib" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpvzS4ce/incremental-state"
[2022-01-19T22:23:20Z DEBUG collector::execute] applying println to "/tmp/.tmpvzS4ce"
[2022-01-19T22:23:20Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Debug, run_kind=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" })
[2022-01-19T22:23:20Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Debug, run_kind=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" })
[2022-01-19T22:23:20Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpvzS4ce#cargo:0.29.0" "--lib" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpvzS4ce/incremental-state"
[2022-01-19T22:23:34Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-01-19T22:23:35Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Opt, run_kind=Some(Full), patch=None
[2022-01-19T22:23:35Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Opt, run_kind=Some(Full), patch=None
[2022-01-19T22:23:35Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpVtgzsJ#cargo:0.29.0" "--release" "--lib" "--" "--wrap-rustc-with" "eprintln"
[2022-01-19T22:24:09Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:24:09Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpVtgzsJ#cargo:0.29.0" "--release" "--lib" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpVtgzsJ/incremental-state"
[2022-01-19T22:24:48Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrUnchanged), patch=None
[2022-01-19T22:24:48Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpVtgzsJ#cargo:0.29.0" "--release" "--lib" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpVtgzsJ/incremental-state"
[2022-01-19T22:24:55Z DEBUG collector::execute] applying println to "/tmp/.tmpVtgzsJ"
[2022-01-19T22:24:55Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" })
[2022-01-19T22:24:55Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" })
[2022-01-19T22:24:55Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpVtgzsJ#cargo:0.29.0" "--release" "--lib" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpVtgzsJ/incremental-state"
Preparing ctfe-stress-4
[2022-01-19T22:25:13Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Check, run_kind=None, patch=None
[2022-01-19T22:25:13Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Debug, run_kind=None, patch=None
[2022-01-19T22:25:13Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Opt, run_kind=None, patch=None
---
[2022-01-19T22:26:11Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-01-19T22:26:11Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Debug, run_kind=Some(Full), patch=None
[2022-01-19T22:26:11Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpMpdald#ctfe-stress-4:0.1.0" "--" "--wrap-rustc-with" "eprintln"
[2022-01-19T22:26:37Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Debug, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:26:37Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpMpdald#ctfe-stress-4:0.1.0" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpMpdald/incremental-state"
[2022-01-19T22:27:07Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Debug, run_kind=Some(IncrUnchanged), patch=None
[2022-01-19T22:27:07Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpMpdald#ctfe-stress-4:0.1.0" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpMpdald/incremental-state"
[2022-01-19T22:27:08Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-01-19T22:27:08Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Opt, run_kind=Some(Full), patch=None
[2022-01-19T22:27:08Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpUzTeSN#ctfe-stress-4:0.1.0" "--release" "--" "--wrap-rustc-with" "eprintln"
[2022-01-19T22:27:33Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:27:33Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:27:33Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpUzTeSN#ctfe-stress-4:0.1.0" "--release" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpUzTeSN/incremental-state"
[2022-01-19T22:28:01Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrUnchanged), patch=None
[2022-01-19T22:28:01Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpUzTeSN#ctfe-stress-4:0.1.0" "--release" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpUzTeSN/incremental-state"
Preparing externs
[2022-01-19T22:28:02Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Check, run_kind=None, patch=None
[2022-01-19T22:28:02Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Debug, run_kind=None, patch=None
[2022-01-19T22:28:02Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Opt, run_kind=None, patch=None
---
[2022-01-19T22:28:02Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-01-19T22:28:02Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Check, run_kind=Some(Full), patch=None
[2022-01-19T22:28:02Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpMgpipA#externs:0.1.0" "--profile" "check" "--" "--wrap-rustc-with" "eprintln"
[2022-01-19T22:28:03Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Check, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:28:03Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpMgpipA#externs:0.1.0" "--profile" "check" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpMgpipA/incremental-state"
[2022-01-19T22:28:04Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Check, run_kind=Some(IncrUnchanged), patch=None
[2022-01-19T22:28:04Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpMgpipA#externs:0.1.0" "--profile" "check" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpMgpipA/incremental-state"
[2022-01-19T22:28:04Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-01-19T22:28:04Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Debug, run_kind=Some(Full), patch=None
[2022-01-19T22:28:04Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpKDGzR9#externs:0.1.0" "--" "--wrap-rustc-with" "eprintln"
[2022-01-19T22:28:05Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Debug, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:28:05Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Debug, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:28:05Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpKDGzR9#externs:0.1.0" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpKDGzR9/incremental-state"
[2022-01-19T22:28:07Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Debug, run_kind=Some(IncrUnchanged), patch=None
[2022-01-19T22:28:07Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpKDGzR9#externs:0.1.0" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpKDGzR9/incremental-state"
[2022-01-19T22:28:08Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-01-19T22:28:08Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Opt, run_kind=Some(Full), patch=None
[2022-01-19T22:28:08Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmp5wty9Q#externs:0.1.0" "--release" "--" "--wrap-rustc-with" "eprintln"
[2022-01-19T22:28:09Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:28:09Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:28:09Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmp5wty9Q#externs:0.1.0" "--release" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmp5wty9Q/incremental-state"
[2022-01-19T22:28:10Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrUnchanged), patch=None
[2022-01-19T22:28:10Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmp5wty9Q#externs:0.1.0" "--release" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmp5wty9Q/incremental-state"
Preparing inflate
[2022-01-19T22:28:11Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Check, run_kind=None, patch=None
[2022-01-19T22:28:11Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Debug, run_kind=None, patch=None
[2022-01-19T22:28:11Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Opt, run_kind=None, patch=None
---
[2022-01-19T22:28:17Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpg31jzt#inflate:0.1.0" "--profile" "check" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpg31jzt/incremental-state"
Running inflate: Debug + [Full, IncrFull, IncrUnchanged, IncrPatched]
[2022-01-19T22:28:19Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-01-19T22:28:19Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Debug, run_kind=Some(Full), patch=None
[2022-01-19T22:28:19Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpacEAXX#inflate:0.1.0" "--" "--wrap-rustc-with" "eprintln"
[2022-01-19T22:28:22Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Debug, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:28:22Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpacEAXX#inflate:0.1.0" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpacEAXX/incremental-state"
[2022-01-19T22:28:26Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Debug, run_kind=Some(IncrUnchanged), patch=None
[2022-01-19T22:28:26Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpacEAXX#inflate:0.1.0" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpacEAXX/incremental-state"
[2022-01-19T22:28:26Z DEBUG collector::execute] applying println to "/tmp/.tmpacEAXX"
[2022-01-19T22:28:26Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Debug, run_kind=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" })
[2022-01-19T22:28:26Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Debug, run_kind=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" })
[2022-01-19T22:28:26Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpacEAXX#inflate:0.1.0" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpacEAXX/incremental-state"
[2022-01-19T22:28:30Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-01-19T22:28:30Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Opt, run_kind=Some(Full), patch=None
[2022-01-19T22:28:30Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmptNaTTe#inflate:0.1.0" "--release" "--" "--wrap-rustc-with" "eprintln"
[2022-01-19T22:28:36Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:28:36Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:28:36Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmptNaTTe#inflate:0.1.0" "--release" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmptNaTTe/incremental-state"
[2022-01-19T22:28:41Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrUnchanged), patch=None
[2022-01-19T22:28:41Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmptNaTTe#inflate:0.1.0" "--release" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmptNaTTe/incremental-state"
[2022-01-19T22:28:41Z DEBUG collector::execute] applying println to "/tmp/.tmptNaTTe"
[2022-01-19T22:28:41Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" })
[2022-01-19T22:28:41Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" })
[2022-01-19T22:28:41Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmptNaTTe#inflate:0.1.0" "--release" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmptNaTTe/incremental-state"
Preparing match-stress-enum
[2022-01-19T22:28:47Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Check, run_kind=None, patch=None
[2022-01-19T22:28:47Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Debug, run_kind=None, patch=None
[2022-01-19T22:28:47Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Opt, run_kind=None, patch=None
[2022-01-19T22:28:47Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Opt, run_kind=None, patch=None
[2022-01-19T22:28:47Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpA2McpU#match-stress-enum:0.1.0" "--release" "--" "--skip-this-rustc"
[2022-01-19T22:28:47Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpuQdRFe#match-stress-enum:0.1.0" "--" "--skip-this-rustc"
[2022-01-19T22:28:47Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpynCp2I#match-stress-enum:0.1.0" "--profile" "check" "--" "--skip-this-rustc"
[2022-01-19T22:28:47Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-01-19T22:28:47Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Check, run_kind=Some(Full), patch=None
[2022-01-19T22:28:47Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpN8UBih#match-stress-enum:0.1.0" "--profile" "check" "--" "--wrap-rustc-with" "eprintln"
[2022-01-19T22:28:49Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Check, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:28:49Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Check, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:28:49Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpN8UBih#match-stress-enum:0.1.0" "--profile" "check" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpN8UBih/incremental-state"
[2022-01-19T22:28:51Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Check, run_kind=Some(IncrUnchanged), patch=None
[2022-01-19T22:28:51Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpN8UBih#match-stress-enum:0.1.0" "--profile" "check" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpN8UBih/incremental-state"
[2022-01-19T22:28:52Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-01-19T22:28:52Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Debug, run_kind=Some(Full), patch=None
[2022-01-19T22:28:52Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpLtXjbE#match-stress-enum:0.1.0" "--" "--wrap-rustc-with" "eprintln"
[2022-01-19T22:28:54Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Debug, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:28:54Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Debug, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:28:54Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpLtXjbE#match-stress-enum:0.1.0" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpLtXjbE/incremental-state"
[2022-01-19T22:28:56Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Debug, run_kind=Some(IncrUnchanged), patch=None
[2022-01-19T22:28:56Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpLtXjbE#match-stress-enum:0.1.0" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpLtXjbE/incremental-state"
[2022-01-19T22:28:57Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-01-19T22:28:57Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Opt, run_kind=Some(Full), patch=None
[2022-01-19T22:28:57Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpGhsbHk#match-stress-enum:0.1.0" "--release" "--" "--wrap-rustc-with" "eprintln"
[2022-01-19T22:28:59Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:28:59Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:28:59Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpGhsbHk#match-stress-enum:0.1.0" "--release" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpGhsbHk/incremental-state"
[2022-01-19T22:29:01Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrUnchanged), patch=None
[2022-01-19T22:29:01Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpGhsbHk#match-stress-enum:0.1.0" "--release" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpGhsbHk/incremental-state"
Preparing token-stream-stress
[2022-01-19T22:29:02Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Check, run_kind=None, patch=None
[2022-01-19T22:29:02Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Opt, run_kind=None, patch=None
[2022-01-19T22:29:02Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Debug, run_kind=None, patch=None
[2022-01-19T22:29:02Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Debug, run_kind=None, patch=None
[2022-01-19T22:29:02Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpk0P72C#token-stream-stress:0.0.0" "--profile" "check" "--bin" "token-stream-stress" "--" "--skip-this-rustc"
[2022-01-19T22:29:02Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpspxH6X#token-stream-stress:0.0.0" "--bin" "token-stream-stress" "--" "--skip-this-rustc"
[2022-01-19T22:29:02Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpqjuIeD#token-stream-stress:0.0.0" "--release" "--bin" "token-stream-stress" "--" "--skip-this-rustc"
[2022-01-19T22:29:03Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-01-19T22:29:03Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Check, run_kind=Some(Full), patch=None
[2022-01-19T22:29:03Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpwxwmrU#token-stream-stress:0.0.0" "--profile" "check" "--bin" "token-stream-stress" "--" "--wrap-rustc-with" "eprintln"
[2022-01-19T22:29:03Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Check, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:29:03Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Check, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:29:03Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpwxwmrU#token-stream-stress:0.0.0" "--profile" "check" "--bin" "token-stream-stress" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpwxwmrU/incremental-state"
[2022-01-19T22:29:03Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Check, run_kind=Some(IncrUnchanged), patch=None
[2022-01-19T22:29:03Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpwxwmrU#token-stream-stress:0.0.0" "--profile" "check" "--bin" "token-stream-stress" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpwxwmrU/incremental-state"
[2022-01-19T22:29:03Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-01-19T22:29:03Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Debug, run_kind=Some(Full), patch=None
[2022-01-19T22:29:03Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Debug, run_kind=Some(Full), patch=None
[2022-01-19T22:29:03Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpDocVxI#token-stream-stress:0.0.0" "--bin" "token-stream-stress" "--" "--wrap-rustc-with" "eprintln"
[2022-01-19T22:29:04Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Debug, run_kind=Some(IncrFull), patch=None
[2022-01-19T22:29:04Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpDocVxI#token-stream-stress:0.0.0" "--bin" "token-stream-stress" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpDocVxI/incremental-state"
[2022-01-19T22:29:04Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Debug, run_kind=Some(IncrUnchanged), patch=None
[2022-01-19T22:29:04Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpDocVxI#token-stream-stress:0.0.0" "--bin" "token-stream-stress" "--" "--wrap-rustc-with" "eprintln" "-C" "incremental=/tmp/.tmpDocVxI/incremental-state"
[2022-01-19T22:29:04Z DEBUG collector::execute] Benchmark iteration 1/1
[2022-01-19T22:29:04Z INFO  collector::execute] run_rustc with incremental=false, build_kind=Opt, run_kind=Some(Full), patch=None
[2022-01-19T22:29:04Z DEBUG collector::execute] "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustc" "--manifest-path" "Cargo.toml" "-p" "file:///tmp/.tmpTFfQ0Q#token-stream-stress:0.0.0" "--release" "--bin" "token-stream-stress" "--" "--wrap-rustc-with" "eprintln"
[2022-01-19T22:29:05Z INFO  collector::execute] run_rustc with incremental=true, build_kind=Opt, run_kind=Some(IncrFull), patch=None
---
[RUSTC-TIMING] serde test:false 3.567
[RUSTC-TIMING] serde_json test:false 1.517
   Compiling rustdoc v0.0.0 (/checkout/src/librustdoc)
[RUSTC-TIMING] rustdoc_json_types test:false 2.395
error[E0615]: attempted to take value of method `ident` on type `&AssocItem`
    --> src/librustdoc/clean/types.rs:2225:72
     |
2225 |             .map(|did| tcx.provided_trait_methods(did).map(|meth| meth.ident.name).collect())
     |
help: use parentheses to call the method
     |
     |
2225 |             .map(|did| tcx.provided_trait_methods(did).map(|meth| meth.ident(_).name).collect())


error[E0615]: attempted to take value of method `ident` on type `&AssocItem`
   --> src/librustdoc/clean/mod.rs:390:60
    |
390 |             name: cx.tcx.associated_item(self.item_def_id).ident.name,
    |
help: use parentheses to call the method
    |
    |
390 |             name: cx.tcx.associated_item(self.item_def_id).ident(_).name,


error[E0615]: attempted to take value of method `ident` on type `&AssocItem`
    --> src/librustdoc/clean/mod.rs:1134:36
     |
1134 |                 let my_name = self.ident.name;
     |
help: use parentheses to call the method
     |
     |
1134 |                 let my_name = self.ident(_).name;


error[E0615]: attempted to take value of method `ident` on type `&AssocItem`
    --> src/librustdoc/clean/mod.rs:1200:60
     |
1200 |         Item::from_def_id_and_parts(self.def_id, Some(self.ident.name), kind, cx)
     |
help: use parentheses to call the method
     |
     |
1200 |         Item::from_def_id_and_parts(self.def_id, Some(self.ident(_).name), kind, cx)


error[E0615]: attempted to take value of method `ident` on type `&AssocItem`
    --> src/librustdoc/clean/mod.rs:1524:72
     |
1524 |                         name: cx.tcx.associated_item(pb.item_def_id()).ident.name,
     |
help: use parentheses to call the method
     |
     |
1524 |                         name: cx.tcx.associated_item(pb.item_def_id()).ident(_).name,


error[E0615]: attempted to take value of method `ident` on type `&AssocItem`
    --> src/librustdoc/clean/mod.rs:1595:50
1595 | ...                   .ident
     |                        ^^^^^ method, not a field
     |
help: use parentheses to call the method
help: use parentheses to call the method
     |
1595 |                                                 .ident(_)


error[E0615]: attempted to take value of method `ident` on type `&AssocItem`
    |
    |
431 |                     .any(|item| item.ident.name == variant_name)
    |
help: use parentheses to call the method
    |
    |
431 |                     .any(|item| item.ident(_).name == variant_name)

For more information about this error, try `rustc --explain E0615`.
[RUSTC-TIMING] rustdoc test:false 2.822
error: could not compile `rustdoc` due to 7 previous errors

Aaron1011 · 2022-01-19T23:11:32Z

@bors try

bors · 2022-01-19T23:11:40Z

⌛ Trying commit c8941d3 with merge 44f1f9005d687620a5221003e5faf61ff125c2cb...

bors · 2022-01-20T00:31:50Z

☀️ Try build successful - checks-actions
Build commit: 44f1f9005d687620a5221003e5faf61ff125c2cb (44f1f9005d687620a5221003e5faf61ff125c2cb)

rust-timer · 2022-01-20T00:31:52Z

Queued 44f1f9005d687620a5221003e5faf61ff125c2cb with parent 5e57faa, future comparison URL.

rust-timer · 2022-01-20T03:31:52Z

Finished benchmarking commit (44f1f9005d687620a5221003e5faf61ff125c2cb): comparison url.

Summary: This change led to large relevant regressions 😿 in compiler performance.

Large regression in instruction counts (up to 2.2% on incr-patched: reverse builds of regex check)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Aaron1011 · 2022-01-20T03:48:42Z

This has slightly better performance than #92837 (which has regressions up to 2.7% compared to 2.2% for this PR)

cjgillot · 2022-01-23T00:41:00Z

This PR is a correctness fix for incremental compilation. This is the lesser of two evil, compared to #92837.
The perf regression seems to come from the increase use of the def_ident_span query.
@rustbot label: +perf-regression-triage
@bors r+

bors · 2022-01-23T00:41:02Z

📌 Commit c8941d3 has been approved by cjgillot

bors · 2022-01-25T11:13:22Z

⌛ Testing commit c8941d3 with merge 502e74f322e2563c8f9f843982445a66a7baf305...

bors · 2022-01-25T15:28:22Z

💥 Test timed out

rust-log-analyzer · 2022-01-25T15:52:02Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Aaron1011 · 2022-01-25T15:58:18Z

@bors retry

bors · 2022-01-25T18:53:49Z

⌛ Testing commit c8941d3 with merge 8cdb3cd...

bors · 2022-01-25T21:56:08Z

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 8cdb3cd to master...

rust-timer · 2022-01-25T23:27:18Z

Finished benchmarking commit (8cdb3cd): comparison url.

Summary: This benchmark run shows 17 relevant regressions 😿 to instruction counts.

Average relevant regression: 0.8%
Largest regression in instruction counts: 2.1% on incr-patched: compile one builds of regex check

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Store a `Symbol` instead of an `Ident` in `AssocItem` This is the same idea as rust-lang#92533, but for `AssocItem` instead of `VariantDef`/`FieldDef`. With this change, we no longer have any uses of `#[stable_hasher(project(...))]`

rust-highfive assigned matthewjasper Jan 19, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 19, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 19, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 19, 2022

This comment has been minimized.

Sign in to view

Store a Symbol instead of an Ident in AssocItem

c8941d3

This is the same idea as rust-lang#92533, but for `AssocItem` instead of `VariantDef`/`FieldDef`. With this change, we no longer have any uses of `#[stable_hasher(project(...))]`

Aaron1011 force-pushed the remove-assoc-ident branch from 188ad3a to c8941d3 Compare January 19, 2022 22:13

rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jan 19, 2022

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 20, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 25, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 25, 2022

bors merged commit 8cdb3cd into rust-lang:master Jan 25, 2022

rustbot added this to the 1.60.0 milestone Jan 25, 2022

bors mentioned this pull request Jan 25, 2022

Continue work on associated const equality #93285

Merged

Aaron1011 mentioned this pull request Jan 26, 2022

Hash full Ident (including Span) in AssocItem #92837

Closed

This was referenced Feb 6, 2022

Investigate usages of #[stable_hasher(project(name))] #91921

Closed

Store a Symbol instead of an Ident in VariantDef/FieldDef #92533

Merged

Aaron1011 mentioned this pull request Feb 18, 2022

ICE index OOB in 1.59.0-beta.8 🚨 #94124

Closed

lqd mentioned this pull request Apr 12, 2022

Found unstable fingerprints for def_ident_span #95945

Open

dario23 added a commit to dario23/rust-semverver that referenced this pull request May 4, 2022

Rustup to rust-lang/rust#93095

caf4a4a

dario23 added a commit to dario23/rust-semverver that referenced this pull request May 6, 2022

Rustup to rust-lang/rust#93095

e997d62

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Store a `Symbol` instead of an `Ident` in `AssocItem` #93095

Store a `Symbol` instead of an `Ident` in `AssocItem` #93095

Aaron1011 commented Jan 19, 2022

rust-highfive commented Jan 19, 2022

Aaron1011 commented Jan 19, 2022

rust-timer commented Jan 19, 2022

bors commented Jan 19, 2022

This comment has been minimized.

rust-log-analyzer commented Jan 19, 2022

Aaron1011 commented Jan 19, 2022

bors commented Jan 19, 2022

bors commented Jan 20, 2022

rust-timer commented Jan 20, 2022

rust-timer commented Jan 20, 2022

Aaron1011 commented Jan 20, 2022

cjgillot commented Jan 23, 2022

bors commented Jan 23, 2022

bors commented Jan 25, 2022

bors commented Jan 25, 2022

rust-log-analyzer commented Jan 25, 2022

Aaron1011 commented Jan 25, 2022

bors commented Jan 25, 2022

bors commented Jan 25, 2022

rust-timer commented Jan 25, 2022

Store a Symbol instead of an Ident in AssocItem #93095

Store a Symbol instead of an Ident in AssocItem #93095

Conversation

Aaron1011 commented Jan 19, 2022

rust-highfive commented Jan 19, 2022

Aaron1011 commented Jan 19, 2022

rust-timer commented Jan 19, 2022

bors commented Jan 19, 2022

This comment has been minimized.

rust-log-analyzer commented Jan 19, 2022

Aaron1011 commented Jan 19, 2022

bors commented Jan 19, 2022

bors commented Jan 20, 2022

rust-timer commented Jan 20, 2022

rust-timer commented Jan 20, 2022

Aaron1011 commented Jan 20, 2022

cjgillot commented Jan 23, 2022

bors commented Jan 23, 2022

bors commented Jan 25, 2022

bors commented Jan 25, 2022

rust-log-analyzer commented Jan 25, 2022

Aaron1011 commented Jan 25, 2022

bors commented Jan 25, 2022

bors commented Jan 25, 2022

rust-timer commented Jan 25, 2022

Store a `Symbol` instead of an `Ident` in `AssocItem` #93095

Store a `Symbol` instead of an `Ident` in `AssocItem` #93095