Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch settings menu to full js #93097

Merged
merged 4 commits into from
May 3, 2022
Merged

Switch settings menu to full js #93097

merged 4 commits into from
May 3, 2022

Commits on Apr 30, 2022

  1. Move settings into full JS

    @GuillaumeGomez
    GuillaumeGomez committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    9625ed8 View commit details
    Browse the repository at this point in the history

  2. Add GUI test for settings menu

    @GuillaumeGomez
    GuillaumeGomez committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    e7d7d75 View commit details
    Browse the repository at this point in the history

  3. Extend settings test to ensure settings text is as expected

    @GuillaumeGomez
    GuillaumeGomez committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    2f074de View commit details
    Browse the repository at this point in the history

Commits on May 1, 2022

  1. * Add documentation for settings page rendering functions. 

    * Improve code.
* Fix some documentation argument types.
* Make settings order the same as before this PR.
* Change timeout to 0 so that browser will render it as fast as possible.
    @GuillaumeGomez
    GuillaumeGomez committed May 1, 2022
    Configuration menu
    Copy the full SHA
    73688e4 View commit details
    Browse the repository at this point in the history