rustdoc: Fix inconsistency of local blanket impls #93169
Conversation
rustbot
added
the
T-rustdoc
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Changes look good to me. Let's run a perf-check just in case: @bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit 66d056a with merge 618360ac8cfc7538d9c2b2dc32ae7773ec3dd58b... |
|
☀️ Try build successful - checks-actions |
|
Queued 618360ac8cfc7538d9c2b2dc32ae7773ec3dd58b with parent ecf7299, future comparison URL. |
|
Finished benchmarking commit (618360ac8cfc7538d9c2b2dc32ae7773ec3dd58b): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
rustbot
removed
the
S-waiting-on-perf
| @@ -4,10 +4,12 @@ | |||
| // @has blanket_with_local.json "$.index[*][?(@.name=='Load')]" | |||
| pub trait Load { | |||
| fn load() {} | |||
| fn write(self) {} | |||
There was a problem hiding this comment.
Since you added this method, shouldn't there be a matching check?
There was a problem hiding this comment.
Should probably add a check for both the methods. The checks are more to ensure the methods exist in the output, so we know we're testing the ICE correctly.
|
Thanks! @bors: r+ |
|
📌 Commit 9220631 has been approved by |
bors
added
S-waiting-on-bors
|
There were no perf effects: @bors rollup=maybe |
…ency, r=GuillaumeGomez Fix inconsistency of local blanket impls When a blanket impl is local, go through HIR instead of middle. This fixes inconsistencies with data detected during JSON generation. Expected this change to take longer. I also tried doing the whole item through existing clean architecture, but it didn't work out trivially, and felt like it would have added more complexity than it removed. Properly fixes rust-lang#83718
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#88794 (Add a `try_clone()` function to `OwnedFd`.) - rust-lang#93064 (Properly track `DepNode`s in trait evaluation provisional cache) - rust-lang#93118 (Move param count error emission to end of `check_argument_types`) - rust-lang#93144 (Work around missing code coverage data causing llvm-cov failures) - rust-lang#93169 (Fix inconsistency of local blanket impls) - rust-lang#93175 (Implement stable overlap check considering negative traits) - rust-lang#93251 (rustdoc settings: use radio buttons for theme) - rust-lang#93269 (Use error-on-mismatch policy for PAuth module flags.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
pnkfelix
changed the title
When a blanket impl is local, go through HIR instead of middle. This fixes inconsistencies with data detected during JSON generation.
Expected this change to take longer. I also tried doing the whole item through existing clean architecture, but it didn't work out trivially, and felt like it would have added more complexity than it removed.
Properly fixes #83718