Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyword_docs: document use of in with pub keyword #93692

Merged
merged 1 commit into from
Mar 19, 2022

Conversation

mfrw
Copy link
Contributor

@mfrw mfrw commented Feb 6, 2022

Signed-off-by: Muhammad Falak R Wani falakreyaz@gmail.com

Fixes: #93609

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 6, 2022
@mfrw
Copy link
Contributor Author

mfrw commented Feb 15, 2022

r? @jyn514

@rust-highfive rust-highfive assigned jyn514 and unassigned joshtriplett Feb 15, 2022
@jyn514
Copy link
Member

jyn514 commented Feb 15, 2022

Please do not assign me. I am not on any documentation team.

r? @joshtriplett

@rust-highfive rust-highfive assigned joshtriplett and unassigned jyn514 Feb 15, 2022
@jyn514
Copy link
Member

jyn514 commented Feb 15, 2022

@rust-lang/infra do you know why it was possible for me to be assigned here?

@mfrw
Copy link
Contributor Author

mfrw commented Feb 16, 2022

Please do not assign me. I am not on any documentation team.

r? @joshtriplett

Apologies, did not know that.

@dtolnay dtolnay assigned dtolnay and unassigned joshtriplett Mar 18, 2022
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Mar 18, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Mar 18, 2022

📌 Commit 6706ab8 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 19, 2022
…olnay

keyword_docs: document use of `in` with `pub` keyword

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>

Fixes: rust-lang#93609
This was referenced Mar 19, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 19, 2022
Rollup of 6 pull requests

Successful merges:

 - rust-lang#92519 (Use verbatim paths for `process::Command` if necessary)
 - rust-lang#92612 (Update stdlib for the l4re target)
 - rust-lang#92663 (Implement `Write for Cursor<[u8; N]>`, plus `A: Allocator` cursor support)
 - rust-lang#93263 (Consistently present absent stdio handles on Windows as NULL handles.)
 - rust-lang#93692 (keyword_docs: document use of `in` with `pub` keyword)
 - rust-lang#94984 (add `CStr` method that accepts any slice containing a nul-terminated string)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 463e516 into rust-lang:master Mar 19, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 19, 2022
@mfrw mfrw deleted the mfrw/document-keyword-in branch March 19, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention in's use for visibility paths, aka pub(in path), in the keyword docs
7 participants