-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure stability directives are checked in all cases #94096
Conversation
are these just the first 7 commits from #93017? and if so, did you change anything meaningful about them after my first review? If not, r=me |
I did not change anything except re-blessing tests after rebase. |
📌 Commit 5ff235b has been approved by |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
🙅 Please do not |
Just in case. |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 5ff235b with merge 1d32a80a10c46744f5200d5dab9e702510d85418... |
☀️ Try build successful - checks-actions |
Queued 1d32a80a10c46744f5200d5dab9e702510d85418 with parent b17226f, future comparison URL. |
Finished benchmarking commit (1d32a80a10c46744f5200d5dab9e702510d85418): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
@bors r=lcnr |
📌 Commit 5ff235b has been approved by |
@bors rollup- |
Ensure stability directives are checked in all cases Split off rust-lang#93017 Stability and deprecation were not checked in all cases, for instance if a type error happened. This PR moves the check earlier in the pipeline to ensure the errors are emitted in all cases. r? `@lcnr`
Looks like tests needs to be reblessed |
4f880ba
to
c680d39
Compare
@bors r=lcnr |
📌 Commit c680d39 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (65f6d33): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Split off #93017
Stability and deprecation were not checked in all cases, for instance if a type error happened.
This PR moves the check earlier in the pipeline to ensure the errors are emitted in all cases.
r? @lcnr