Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename unix::net::SocketAddr::from_path to from_pathname and stabilize it #94356

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Rename unix::net::SocketAddr::from_path to from_pathname and stabilize it #94356

merged 2 commits into from
Mar 11, 2022

Conversation

Thomasdezeeuw
Copy link
Contributor

Stabilizes unix_socket_creation.

Closes #93423
r? @m-ou-se

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 25, 2022
@m-ou-se m-ou-se added A-io Area: std::io, std::fs, std::net and std::path T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Feb 25, 2022
@m-ou-se
Copy link
Member

m-ou-se commented Feb 25, 2022

@rfcbot merge

This stabilizes #93423, and renames the method from from_path to from_pathname, to make it consistent with the already existing as_pathname method. That solves the only unresolved question in the tracking issue.

@rfcbot
Copy link

rfcbot commented Feb 25, 2022 •
edited by dtolnay
Loading

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Feb 25, 2022
@m-ou-se m-ou-se mentioned this pull request Feb 25, 2022
Closed
4 tasks
@Thomasdezeeuw
Copy link
Contributor Author

Since the change is so small I've force push to change to stabilise in 1.61.

@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Feb 28, 2022
@rfcbot
Copy link

rfcbot commented Feb 28, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Feb 28, 2022
@m-ou-se m-ou-se added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2022
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Mar 10, 2022
@rfcbot
Copy link

rfcbot commented Mar 10, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@dtolnay
Copy link
Member

dtolnay commented Mar 11, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Mar 11, 2022

📌 Commit a84e77b has been approved by dtolnay

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 11, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 11, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2022
@bors
Auto merge of rust-lang#94834 - Dylan-DPC:rollup-sza4qc2, r=Dylan-DPC
8756ed2 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#93293 (Implement `MIN`/`MAX` constants for non-zero integers)
 - rust-lang#94356 (Rename unix::net::SocketAddr::from_path to from_pathname and stabilize it)
 - rust-lang#94765 (Rename is_{some,ok,err}_with to is_{some,ok,err}_and.)
 - rust-lang#94819 (configure: don't serialize empty array elements)
 - rust-lang#94826 (Improve doc wording for retain on some collections)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ab85165 into rust-lang:master Mar 11, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 11, 2022
@Thomasdezeeuw Thomasdezeeuw deleted the stabilize_unix_socket_creation branch March 11, 2022 09:09
@m-ou-se
Copy link
Member

m-ou-se commented Mar 11, 2022

🎉 Thanks, @Thomasdezeeuw, for pushing this towards stabilization. :)

@Thomasdezeeuw Thomasdezeeuw mentioned this pull request Mar 11, 2022
Closed
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Mar 17, 2022
@dtolnay dtolnay self-assigned this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss left review comments

@dtolnay dtolnay dtolnay approved these changes

Assignees

@m-ou-se m-ou-se

@dtolnay dtolnay

Labels
A-io Area: std::io, std::fs, std::net and std::path disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for unix_socket_creation
9 participants
@Thomasdezeeuw @m-ou-se @rfcbot @dtolnay @bors @ehuss @apiraino @rust-highfive @rustbot