-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #94392
Rollup of 5 pull requests #94392
Commits on Feb 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 06ac05a - Browse repository at this point
Copy the full SHA 06ac05aView commit details
Commits on Feb 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c6f5c7b - Browse repository at this point
Copy the full SHA c6f5c7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8bd997 - Browse repository at this point
Copy the full SHA b8bd997View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1d8ce4 - Browse repository at this point
Copy the full SHA a1d8ce4View commit details
Commits on Feb 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4d89292 - Browse repository at this point
Copy the full SHA 4d89292View commit details
Commits on Feb 25, 2022
-
Do not suggest using a const parameter when there are bounds on an un…
…used type parameter The user wrote the bound, so it's obvious they want a type.
Configuration menu - View commit details
-
Copy full SHA for 4520045 - Browse repository at this point
Copy the full SHA 4520045View commit details
Commits on Feb 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6747458 - Browse repository at this point
Copy the full SHA 6747458View commit details -
Rollup merge of rust-lang#93400 - ChayimFriedman2:dont-suggest-using-…
…const-with-bounds-unused-generic-param, r=jackh726 Do not suggest using a const parameter when there are bounds on an unused type parameter The user wrote the bound, so it's obvious they want a type.
Configuration menu - View commit details
-
Copy full SHA for be9b99b - Browse repository at this point
Copy the full SHA be9b99bView commit details -
Rollup merge of rust-lang#93982 - nbdd0121:explicit-generic-args, r=j…
…ackh726 Provide extra note if synthetic type args are specified Implement the unresolved question in rust-lang#83701 as suggested in rust-lang#86176 (comment). r? ``@jackh726``
Configuration menu - View commit details
-
Copy full SHA for 5dcee68 - Browse repository at this point
Copy the full SHA 5dcee68View commit details -
Rollup merge of rust-lang#94087 - tmiasko:rm-ignore-borrow-on-drop, r…
…=jackh726 Remove unused `unsound_ignore_borrow_on_drop`
Configuration menu - View commit details
-
Copy full SHA for 734b924 - Browse repository at this point
Copy the full SHA 734b924View commit details -
Rollup merge of rust-lang#94235 - Dirbaio:fix-chalk-opaque-debrujin, …
…r=jackh726 chalk: Fix wrong debrujin index in opaque type handling. A folder in opaque type lowering was substituting all opaque type references with a variable with debrujin index 0 ignoring how many binders deep we are. This caused an ICE with `Not enough bound vars: ^0 not found in []` ([full logs](https://gist.github.com/Dirbaio/2b9374ff4fce37afb9d665dc9f0000df)) with the following code. ```rust fn main() -> () {} async fn foo(x: u32) -> u32 { x } ``` With the fix, it no longer ICEs. It still doesn't typecheck due to generator issues. I've added a "known-bug" test so that at least it doesn't regress back to ICEing. r? ``@jackh726``
Configuration menu - View commit details
-
Copy full SHA for d6ca388 - Browse repository at this point
Copy the full SHA d6ca388View commit details -
Rollup merge of rust-lang#94306 - Mark-Simulacrum:dom-fixups, r=jackh726
Avoid exhausting stack space in dominator compression Doesn't add a test case -- I ended up running into this while playing with the generated example from rust-lang#43578, which we could do with a run-make test (to avoid checking a large code snippet into tree), but I suspect we don't want to wait for it to compile (locally it takes ~14s -- not terrible, but doesn't seem worth it to me). In practice stack space exhaustion is difficult to test for, too, since if we set the bound too low a different call structure above us (e.g., a nearer ensure_sufficient_stack call) would let the test pass even with the old impl, most likely. Locally it seems like this manages to perform approximately equivalently to the recursion, but will run perf to confirm.
Configuration menu - View commit details
-
Copy full SHA for 648a8e3 - Browse repository at this point
Copy the full SHA 648a8e3View commit details