Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #94430

Closed
wants to merge 19 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

light4 and others added 19 commits February 25, 2022 20:00
It is currently hard coded to llvm if enabled and cranelift otherwise.
This made some sense when cranelift was the only alternative codegen
backend. Since the introduction of the gcc backend this doesn't make
much sense anymore. Before this PR bootstrapping rustc using a backend
other than llvm or cranelift required changing the source of
rustc_interface. With this PR it becomes a matter of putting the right
backend as first enabled backend in config.toml.
Fix show error message when literal overflows in match patterns

Fix rust-lang#94239
This changes overflow behavior in [fn lit_to_const](https://github.com/rust-lang/rust/blob/master/compiler/rustc_mir_build/src/thir/constant.rs#L10)
…an-DPC

1 - Make more use of `let_chains`

Continuation of rust-lang#94376.

cc rust-lang#53667
…ion, r=cjgillot

Document that pre-expansion lint passes are softly deprecated

The pre-expansion lint pass has been softly deprecated since rust-lang#69838. Every once in a while I see someone mention it as a possibility, only get the feedback that it's deprecated. This PR officially documents that the method is soft deprecated to have a single point of truth for it.

That's it. Have a great rest of the day 🙃

---

* See [rust#69838](rust-lang#69838)
* See [rust-clippy#5518](rust-lang/rust-clippy#5518)
…5, r=matthiaskrgr

Add test for rust-lang#79465 to prevent regression

Fixes rust-lang#79465.

Like this we will be able to close the issue.

r? ```@matthiaskrgr```
avoid rebuilding bootstrap when PATH changes

Fixes rust-lang#94408

r? ``@Mark-Simulacrum``
…Simulacrum

Use the first codegen backend in the config.toml as default

It is currently hard coded to llvm if enabled and cranelift otherwise.
This made some sense when cranelift was the only alternative codegen
backend. Since the introduction of the gcc backend this doesn't make
much sense anymore. Before this PR bootstrapping rustc using a backend
other than llvm or cranelift required changing the source of
rustc_interface. With this PR it becomes a matter of putting the right
backend as first enabled backend in config.toml.

cc ``@antoyo``
…links, r=notriddle

Fix duplicated impl links

Fixes rust-lang#78701.

The problem is that the blanket impl has the same ID as the other impl, except that we don't derive IDs when we generate the sidebar. We now do.

r? `@notriddle`
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Feb 27, 2022
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=8

@bors
Copy link
Contributor

bors commented Feb 27, 2022

📌 Commit 8ab2dcc has been approved by matthiaskrgr

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 27, 2022
@bors
Copy link
Contributor

bors commented Feb 27, 2022

⌛ Testing commit 8ab2dcc with merge 4253cce584af151f38e2569409bd2bd194ac1d48...

@rust-log-analyzer
Copy link
Collaborator

The job dist-i586-gnu-i586-i686-musl failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Dropping 2
Dropping 3
Dropping 4
------------------------------------------
--- stderr -------------------------------
thread '<unnamed>' panicked at 'Oh no', /checkout/src/test/ui/array-slice-vec/box-of-array-of-drop-1.rs:31:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'expect: 0xffffffff actual: 0x56781234', /checkout/src/test/ui/array-slice-vec/box-of-array-of-drop-1.rs:52:5


---- [ui] ui/array-slice-vec/box-of-array-of-drop-2.rs stdout ----

---
Dropping 2
Dropping 3
Dropping 4
------------------------------------------
--- stderr -------------------------------
thread '<unnamed>' panicked at 'Oh no', /checkout/src/test/ui/array-slice-vec/box-of-array-of-drop-2.rs:31:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'expect: 0xffffffff actual: 0x56781234', /checkout/src/test/ui/array-slice-vec/box-of-array-of-drop-2.rs:52:5


---- [ui] ui/array-slice-vec/nested-vec-3.rs stdout ----

---
Dropping 2
Dropping 3
Dropping 4
------------------------------------------
--- stderr -------------------------------
thread '<unnamed>' panicked at 'Oh no', /checkout/src/test/ui/array-slice-vec/nested-vec-3.rs:32:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'expect: 0xffffffff actual: 0x56781234', /checkout/src/test/ui/array-slice-vec/nested-vec-3.rs:59:5



failures:

@bors
Copy link
Contributor

bors commented Feb 27, 2022

💔 Test failed - checks-actions

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 27, 2022
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2022
@matthiaskrgr matthiaskrgr deleted the rollup-80w9cnk branch March 11, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants