Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move transmute_undefined_repr back to nursery again #94536

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Mar 2, 2022

This PR reapplies #94014, which was reverted unintentionally I think by #94329. The combination of rust-lang/rust-clippy#8432 + rust-lang/rust-clippy#8497 in clippy should prevent this from happening again.

r? @Manishearth

There's still open discussion if this lint is ready to be enabled by
default. We want to give us more time to figure this out and prevent
this lint from getting to stable as an enabled-by-default lint.
@rust-highfive
Copy link
Collaborator

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 2, 2022
@Manishearth
Copy link
Member

@bors r+

tbh i'd rather just wait for the next sync to avoid further complications, but I guess this works.

@bors
Copy link
Contributor

bors commented Mar 2, 2022

📌 Commit 76f0305 has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2022
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#93562 (Update the documentation for `{As,Into,From}Raw{Fd,Handle,Socket}`.)
 - rust-lang#94101 (rustdoc: add test cases for hidden enum variants)
 - rust-lang#94484 (8 - Make more use of `let_chains`)
 - rust-lang#94522 (Remove out-of-context line at end of E0284 message)
 - rust-lang#94534 (Re-export (unstable) core::ffi types from std::ffi)
 - rust-lang#94536 (Move transmute_undefined_repr back to nursery again)
 - rust-lang#94537 (Use ? operator in one instance instead of manual match)
 - rust-lang#94544 (Add some examples to comments in mbe code)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 250e7e1 into rust-lang:master Mar 3, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 3, 2022
@dtolnay dtolnay deleted the transmute branch April 3, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants