Add missing links in platform support docs #94605
Conversation
Also sort sidebar alphabetically by document filename
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Looks good to me, thanks! I'll let someone from the compiler team make the final approval. r? @pnkfelix |
| - [armv7-unknown-linux-uclibceabi](platform-support/armv7-unknown-linux-uclibceabi.md) | ||
| - [armv7-unknown-linux-uclibceabihf](platform-support/armv7-unknown-linux-uclibceabihf.md) | ||
| - [aarch64-unknown-none-hermitkernel](platform-support/aarch64-unknown-none-hermitkernel.md) | ||
| - [\*-kmc-solid_\*](platform-support/kmc-solid.md) |
There was a problem hiding this comment.
| - [\*-kmc-solid_\*](platform-support/kmc-solid.md) | |
| - [*-kmc-solid_*](platform-support/kmc-solid.md) |
It's not rendering them correctly with \ before the star.
There was a problem hiding this comment.
Tested it locally on mdBook 0.4.15 it doesn't seem to solve it. I tried a few more combinations and it seems that this works:
| - [\*-kmc-solid_\*](platform-support/kmc-solid.md) | |
| - [\*-kmc-solid_\\*](platform-support/kmc-solid.md) |
as well as
| - [\*-kmc-solid_\*](platform-support/kmc-solid.md) | |
| - [\\*-kmc-solid_\*](platform-support/kmc-solid.md) |
but I'm not seeing a working option with equal number of \ or no \ at all
There was a problem hiding this comment.
@Michcioperz can you clarify whether one of the suggestions you have written here should be adopted?
There was a problem hiding this comment.
This is a bug with mdbook. I posted a fix at rust-lang/mdBook#1785. I recommend leaving it as the original [\*-kmc-solid_\*]. I'll publish a new version of mdbook soon and push a new PR here and that should fix the rendering.
JohnCSimon
added
S-waiting-on-review
|
r=me once the author has resolved the question about the |
pnkfelix
added
S-waiting-on-author
|
📌 Commit c1d5c2b has been approved by |
bors
added
S-waiting-on-bors
Add missing links in platform support docs I was looking at m68k support and saw that https://doc.rust-lang.org/rustc/platform-support.html and the sidebar there were missing some links to target documentation
Add missing links in platform support docs I was looking at m68k support and saw that https://doc.rust-lang.org/rustc/platform-support.html and the sidebar there were missing some links to target documentation
Add missing links in platform support docs I was looking at m68k support and saw that https://doc.rust-lang.org/rustc/platform-support.html and the sidebar there were missing some links to target documentation
Rollup of 9 pull requests Successful merges: - rust-lang#93969 (Only add codegen backend to dep info if -Zbinary-dep-depinfo is used) - rust-lang#94605 (Add missing links in platform support docs) - rust-lang#95372 (make unaligned_references lint deny-by-default) - rust-lang#95859 (Improve diagnostics for unterminated nested block comment) - rust-lang#95961 (implement SIMD gather/scatter via vector getelementptr) - rust-lang#96004 (Consider lifetimes when comparing types for equality in MIR validator) - rust-lang#96050 (Remove some now-dead code that was only relevant before deaggregation.) - rust-lang#96070 ([test] Add test cases for untested functions for BTreeMap) - rust-lang#96099 (MaybeUninit array cleanup) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
I was looking at m68k support and saw that https://doc.rust-lang.org/rustc/platform-support.html and the sidebar there were missing some links to target documentation