Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ICE when using Box<T, A>, again #94873

Merged
merged 1 commit into from
Mar 12, 2022
Merged

Fix ICE when using Box<T, A>, again #94873

merged 1 commit into from
Mar 12, 2022

Conversation

beepster4096
Copy link
Contributor

Sequel to #94043, fixes #94835.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 12, 2022
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Mar 12, 2022

r? @oli-obk

@bors r+ rollup

These patches make me think we should put more of an effort into making Box less special. I would like to revert all these patches some day.

But for now 👍

@bors
Copy link
Contributor

bors commented Mar 12, 2022

📌 Commit 9d72dd5 has been approved by oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned davidtwco Mar 12, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2022
@bors
Copy link
Contributor

bors commented Mar 12, 2022

⌛ Testing commit 9d72dd5 with merge ed2a69c...

@bors
Copy link
Contributor

bors commented Mar 12, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing ed2a69c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 12, 2022
@bors bors merged commit ed2a69c into rust-lang:master Mar 12, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 12, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ed2a69c): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@beepster4096 beepster4096 mentioned this pull request Apr 1, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 21, 2022
@bors
Auto merge of rust-lang#95576 - DrMeepster:box_erasure, r=oli-obk
a25b131 
Remove dereferencing of Box from codegen

Through rust-lang#94043, rust-lang#94414, rust-lang#94873, and rust-lang#95328, I've been fixing issues caused by Box being treated like a pointer when it is not a pointer. However, these PRs just introduced special cases for Box. This PR removes those special cases and instead transforms a deref of Box into a deref of the pointer it contains.

Hopefully, this is the end of the Box<T, A> ICEs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

ICE when dereferencing Box<T, &A>
7 participants
@beepster4096 @rust-highfive @oli-obk @bors @rust-timer @davidtwco @rustbot