Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diagnostics: regression test for <usize as Iterator>::rev #94893

Merged
merged 1 commit into from
Apr 24, 2022
Merged

diagnostics: regression test for <usize as Iterator>::rev #94893

merged 1 commit into from
Apr 24, 2022

Conversation

notriddle
Copy link
Contributor

Closes #90315

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 12, 2022
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2022
@notriddle notriddle force-pushed the notriddle/regression-test-issue-90315 branch from 1f7077a to b3a5088 Compare March 12, 2022 20:11
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2022
@JohnCSimon
Copy link
Member

Triage

@notriddle - It looks like I've set this as ready for review.
I set it using @rustbot ready

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 23, 2022
@Mark-Simulacrum Mark-Simulacrum force-pushed the notriddle/regression-test-issue-90315 branch from 4153748 to 40c9bc0 Compare April 24, 2022 15:14
@Mark-Simulacrum
Copy link
Member

Squashed the commits.

@bors r+

@bors
Copy link
Contributor

bors commented Apr 24, 2022

📌 Commit 40c9bc0 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 24, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2022
@bors
Auto merge of rust-lang#96363 - matthiaskrgr:rollup-mthdja5, r=matthi…
5cdab3a 
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#94893 (diagnostics: regression test for `<usize as Iterator>::rev`)
 - rust-lang#95504 (Add `x {check,build,doc} {compiler,library}` aliases.)
 - rust-lang#96237 (compiletest: combine `--*-python` args)
 - rust-lang#96303 (Improve bootstrap tests)
 - rust-lang#96352 (Improve span for `consider adding an explicit lifetime bound` suggestions under NLL)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ce0473e into rust-lang:master Apr 24, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 24, 2022
@notriddle notriddle deleted the notriddle/regression-test-issue-90315 branch April 24, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

"the method rev() exists on usize" is misleading
6 participants
@notriddle @rust-highfive @JohnCSimon @Mark-Simulacrum @bors @rustbot