Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecated_safe feature gate and attribute, cc #94978 #94982

Merged
merged 1 commit into from Mar 18, 2022
Merged

Add deprecated_safe feature gate and attribute, cc #94978 #94982

merged 1 commit into from Mar 18, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 15, 2022

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 15, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @davidtwco (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2022
@ghost ghost mentioned this pull request Mar 15, 2022
Open
6 tasks
jhpratt
jhpratt approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@jhpratt jhpratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in terms of adding the attribute itself (there's obviously no functionality here yet).

@Dylan-DPC
Copy link
Member

r? @Dylan-DPC

@rust-highfive rust-highfive assigned Dylan-DPC and unassigned davidtwco Mar 16, 2022
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 16, 2022

📌 Commit e4f1179 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2022
@bors
Copy link
Contributor

bors commented Mar 16, 2022

⌛ Testing commit e4f1179 with merge 4fdf6a26e9dfe51547ebdac795dffa3a4df3edc3...

@bors
Copy link
Contributor

bors commented Mar 16, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 16, 2022
@ghost
Copy link
Author

ghost commented Mar 16, 2022 •
edited by ghost
Loading

Is the build failure related to my change? I'm looking here: https://github.com/rust-lang-ci/rust/runs/5570015260?check_suite_focus=true

I see 5 build attempts in this log, each ending with:

The command '/bin/sh -c /scripts/cmake.sh' returned a non-zero code: 1

I'm not sure if this is the source of the cmake error, but I also see this in each build attempt:

/scripts/cmake.sh: line 14: /tmp/build.log: Permission denied
ERROR: An error was encountered with the build.

@Dylan-DPC
Copy link
Member

@bors r+

@Dylan-DPC
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Mar 16, 2022

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Mar 16, 2022

📌 Commit e4f1179 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2022
@bors
Copy link
Contributor

bors commented Mar 16, 2022

⌛ Testing commit e4f1179 with merge 1177e7b2ffb37d4052e1bba8eff7fa727f4323d2...

@bors
Copy link
Contributor

bors commented Mar 16, 2022

⌛ Testing commit e4f1179 with merge 8385dc2345594af5089ae482ac85ed5607a28544...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Mar 16, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 16, 2022
@ghost
Copy link
Author

ghost commented Mar 16, 2022

Not sure if this is spurious or if I've done something wrong here.

@Dylan-DPC
Copy link
Member

nah some other prs are failing with the same problem

@Dylan-DPC
Copy link
Member

@bors ping

@Dylan-DPC
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2022
@bors
Copy link
Contributor

bors commented Mar 16, 2022

😪 I'm awake I'm awake

@Dylan-DPC Dylan-DPC mentioned this pull request Mar 17, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 18, 2022
@bors
Auto merge of rust-lang#95056 - Dylan-DPC:rollup-swtuw2n, r=Dylan-DPC
cd11905 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#91133 (Improve `unsafe` diagnostic)
 - rust-lang#93222 (Make ErrorReported impossible to construct outside `rustc_errors`)
 - rust-lang#93745 (Stabilize ADX target feature)
 - rust-lang#94309 ([generator_interior] Be more precise with scopes of borrowed places)
 - rust-lang#94698 (Remove redundant code from copy-suggestions)
 - rust-lang#94731 (Suggest adding `{ .. }` around a const function call with arguments)
 - rust-lang#94960 (Fix many spelling mistakes)
 - rust-lang#94982 (Add deprecated_safe feature gate and attribute, cc rust-lang#94978)
 - rust-lang#94997 (debuginfo: Fix ICE when generating name for type that produces a layout error.)
 - rust-lang#95000 (Fixed wrong type name in comment)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0c73b25 into rust-lang:master Mar 18, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 18, 2022
@Jerrody Jerrody mentioned this pull request Mar 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Dylan-DPC Dylan-DPC

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
8 participants
@rust-highfive @Dylan-DPC @bors @rust-log-analyzer @jhpratt @davidtwco @rustbot @User1785604260