Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 5 pull requests #95382

Merged
merged 13 commits into from
Mar 28, 2022
Merged

Rollup of 5 pull requests #95382

merged 13 commits into from
Mar 28, 2022

Conversation

Dylan-DPC
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

smoelius and others added 13 commits March 24, 2022 20:08
@smoelius
Implement apply_switch_int_edge_effects for backward analyses
ee7413b
@smoelius
Address review comments
37ebd47 
* Add lazily computed `switch_sources` data structure
* Don't assume a target has only one associated value
@GuillaumeGomez
Add long error explanation for E0667
eae2903
@c410-f3r
Remove duplicated test files
3a51029
@lopopolo
Fix typo in String::try_reserve_exact docs
1ba8851 
Copying the pattern from `Vec::try_reserve_exact` and `String::try_reserve`,
it looks like this doc comment is intending to refer to the currently-being-documented
function.
@notriddle
diagnostics: suggest missing comma in bad FRU syntax
301fc07 
Fixes rust-lang#51103
@GuillaumeGomez
Update ui test output
81f24c1
@ecstatic-morse
Nit
241ec5b
@Dylan-DPC
Rollup merge of rust-lang#94939 - notriddle:notriddle/fru-comma-sugge…
726cd73 
…stion, r=cjgillot

diagnostics: suggest missing comma in bad FRU syntax

Fixes rust-lang#51103
@Dylan-DPC
Rollup merge of rust-lang#95120 - smoelius:backward-switch-int, r=ecs…
a8be562 
…tatic-morse

Implement `apply_switch_int_edge_effects` for backward analyses

See rust-lang#94576 for some discussion.

r? `@ecstatic-morse`
@Dylan-DPC
Rollup merge of rust-lang#95364 - GuillaumeGomez:long-error-explanati…
dafc29d 
…on-e0667, r=Dylan-DPC

Add long error explanation for E0667

Part of rust-lang#61137.
@Dylan-DPC
Rollup merge of rust-lang#95366 - c410-f3r:moar-tests, r=petrochenkov
1367ede 
Remove test files with duplicated checksums

cc rust-lang#73494
r? `@petrochenkov`
@Dylan-DPC
Rollup merge of rust-lang#95368 - lopopolo:lopopolo/string-try-reserv…
eca2531 
…e-exact-doc-typo, r=Dylan-DPC

Fix typo in `String::try_reserve_exact` docs

Copying the pattern from `Vec::try_reserve_exact` and `String::try_reserve`,
it looks like this doc comment is intending to refer to the currently-being-documented
function.
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Mar 27, 2022
@Dylan-DPC
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Mar 27, 2022

📌 Commit eca2531 has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 27, 2022
@bors
Copy link
Contributor

bors commented Mar 27, 2022

⌛ Testing commit eca2531 with merge 6252304...

@bors
Copy link
Contributor

bors commented Mar 28, 2022

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 6252304 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 28, 2022
@bors bors merged commit 6252304 into rust-lang:master Mar 28, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 28, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6252304): comparison url.

Summary: This benchmark run shows 4 relevant improvements 🎉 but 7 relevant regressions 😿 to instruction counts.

  • Arithmetic mean of relevant regressions: 2.2%
  • Arithmetic mean of relevant improvements: -0.4%
  • Arithmetic mean of all relevant changes: 1.2%
  • Largest improvement in instruction counts: -0.4% on incr-unchanged builds of deeply-nested-multi check
  • Largest regression in instruction counts: 3.2% on full builds of await-call-tree check

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

@rustbot rustbot added the perf-regression Performance regression. label Mar 28, 2022
@pnkfelix
Copy link
Member

Visiting for weekly performance triage.

Changes to the primary benchmarks seem like a wash and probably ignorable (0.33% worse for unicode-normalization-0.1.19, 0.33% better for ripgrep-13.0.0).

Changes to the secondary benchmarks are slightly more concerning: namely, 3% worse for await-call-tree (on six scenarios).

If I had to guess, I'd assume that this impact was caused by PR #95120; the other PRs in this rollup seem very innocuous, while PR #95120 is (slightly(?)) more invasive.

I'm going to leave this as untriaged for now.

@Dylan-DPC
Copy link
Member Author

@pnkfelix would trying a revert of #95120 and checking the perf be a good idea ?

@JakobDegen
Copy link
Contributor

Pinging @pnkfelix to let you know that #96838 has been merged, which I believe should allow us to mark this as triaged, since it seems to recover the problematic 3% slowdowns

@pierwill pierwill mentioned this pull request May 10, 2022
Closed
@tmiasko tmiasko added the perf-regression-triaged The performance regression has been triaged. label May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.