Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable #[thread_local] support on i686-pc-windows-msvc #95430

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

ChrisDenton
Copy link
Member

Fixes #95429

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 29, 2022
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 29, 2022
@klensy
Copy link
Contributor

klensy commented Mar 29, 2022

Isn't disabling things for whole platform without clear reproducible test is too fast decision?

@ChrisDenton
Copy link
Member Author

While not ideal, this is basically just reverting to the previous status quo. And there have been known issues in the past, which is why it was originally not enabled. Even now there are still issues with dylibs due to TLS being scoped to the dll/exe rather than global to the process.

@nagisa
Copy link
Member

nagisa commented Mar 31, 2022

@bors r+, but it would be great if we could get the reporter to produce a minimal reproducer which we could convert into a test.

@davidtwco
Copy link
Member

Looks like bors missed that comment.

r? @nagisa
@bors r=nagisa

@bors
Copy link
Contributor

bors commented Apr 1, 2022

📌 Commit 017a092 has been approved by nagisa

@rust-highfive rust-highfive assigned nagisa and unassigned davidtwco Apr 1, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2022
Rollup of 8 pull requests

Successful merges:

 - rust-lang#95354 (Handle rustc_const_stable attribute in library feature collector)
 - rust-lang#95373 (invalid_value lint: detect invalid initialization of arrays)
 - rust-lang#95430 (Disable #[thread_local] support on i686-pc-windows-msvc)
 - rust-lang#95544 (Add error message suggestion for missing noreturn in naked function)
 - rust-lang#95556 (Implement provenance preserving methods on NonNull)
 - rust-lang#95557 (Fix `thread_local!` macro to be compatible with `no_implicit_prelude`)
 - rust-lang#95559 (small type system refactoring)
 - rust-lang#95560 (convert more `DefId`s to `LocalDefId`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 46a4754 into rust-lang:master Apr 2, 2022
@rustbot rustbot added this to the 1.61.0 milestone Apr 2, 2022
@ChrisDenton ChrisDenton deleted the disable-tls-i686-msvc branch April 2, 2022 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#[thread_local] on i686 windows msvc causes suspicious crash in production
7 participants