-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable #[thread_local] support on i686-pc-windows-msvc #95430
Conversation
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
|
Isn't disabling things for whole platform without clear reproducible test is too fast decision? |
While not ideal, this is basically just reverting to the previous status quo. And there have been known issues in the past, which is why it was originally not enabled. Even now there are still issues with dylibs due to TLS being scoped to the dll/exe rather than global to the process. |
@bors r+, but it would be great if we could get the reporter to produce a minimal reproducer which we could convert into a test. |
📌 Commit 017a092 has been approved by |
Rollup of 8 pull requests Successful merges: - rust-lang#95354 (Handle rustc_const_stable attribute in library feature collector) - rust-lang#95373 (invalid_value lint: detect invalid initialization of arrays) - rust-lang#95430 (Disable #[thread_local] support on i686-pc-windows-msvc) - rust-lang#95544 (Add error message suggestion for missing noreturn in naked function) - rust-lang#95556 (Implement provenance preserving methods on NonNull) - rust-lang#95557 (Fix `thread_local!` macro to be compatible with `no_implicit_prelude`) - rust-lang#95559 (small type system refactoring) - rust-lang#95560 (convert more `DefId`s to `LocalDefId`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #95429