Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Only show associated consts from inherent impls in sidebar #95475

Conversation

Jules-Bertholet
Copy link
Contributor

Resolves #95459

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Mar 30, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jsha (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2022
@rust-log-analyzer

This comment has been minimized.

@Jules-Bertholet Jules-Bertholet force-pushed the rustdoc-hide-assoc-consts-from-trait-impls branch from dda1cd3 to 4d0510c Compare March 30, 2022 17:16
@rust-log-analyzer

This comment has been minimized.

@Jules-Bertholet Jules-Bertholet force-pushed the rustdoc-hide-assoc-consts-from-trait-impls branch from 4d0510c to c8ab63b Compare March 30, 2022 17:50
@jsha
Copy link
Contributor

jsha commented Mar 31, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 31, 2022

📌 Commit c8ab63b has been approved by jsha

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 31, 2022
…consts-from-trait-impls, r=jsha

rustdoc: Only show associated consts from inherent impls in sidebar

Resolves rust-lang#95459
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 1, 2022
…consts-from-trait-impls, r=jsha

rustdoc: Only show associated consts from inherent impls in sidebar

Resolves rust-lang#95459
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 1, 2022
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#95475 (rustdoc: Only show associated consts from inherent impls in sidebar)
 - rust-lang#95516 (ptr_metadata test: avoid ptr-to-int transmutes)
 - rust-lang#95528 (skip slow int_log tests in Miri)
 - rust-lang#95531 (expand: Do not count metavar declarations on RHS of `macro_rules`)
 - rust-lang#95532 (make utf8_char_counts test faster in Miri)
 - rust-lang#95546 (add notes about alignment-altering reallocations to Allocator docs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e21b27f into rust-lang:master Apr 1, 2022
@rustbot rustbot added this to the 1.61.0 milestone Apr 1, 2022
@Jules-Bertholet Jules-Bertholet deleted the rustdoc-hide-assoc-consts-from-trait-impls branch April 1, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc: Rustdoc lists associated consts from trait impls in sidebar
6 participants