rustdoc: do not show primitives and keywords as private #95530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in cc @camelid |
rustbot
added
the
T-rustdoc
|
r? @jsha (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jsha
reviewed
Mar 31, 2022
| @@ -12,6 +12,7 @@ | |||
| // @has foo/index.html '//a/@href' '../foo/index.html' | |||
| // @!has foo/foo/index.html | |||
| // @!has-dir foo/foo | |||
| // @!has foo/index.html '//span' '🔒' | |||
There was a problem hiding this comment.
Optional: You could make this test more robust by specifying that 🔒 should not appear anywhere in the whole page. I think you can do that by using / as the path (selecting the root element), because the string match part uses substring matching.
Also it occurs to me that we will have to be careful to update these negative tests if/when we switch the emoji to an SVG icon.
There was a problem hiding this comment.
13: Non-absolute XPath is not supported due to implementation issues
// @!has foo/index.html '/' '🔒'
|
Looks good to me, with the one testing comment above. r=me once you've addressed that or decided against it. |
|
@bors r=jsha |
|
📌 Commit 2983698 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 31, 2022
…, r=jsha rustdoc: do not show primitives and keywords as private Fixes this: 
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 1, 2022
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#95032 (Clean up, categorize and sort unstable features in std.) - rust-lang#95260 (Better suggestions for `Fn`-family trait selection errors) - rust-lang#95293 (suggest wrapping single-expr blocks in square brackets) - rust-lang#95344 (Make `impl Debug for rustdoc::clean::Item` easier to read) - rust-lang#95388 (interpret: make isize::MAX the limit for dynamic value sizes) - rust-lang#95530 (rustdoc: do not show primitives and keywords as private) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this: