Update libc to 0.2.121 #95688
Merged
Update libc to 0.2.121 #95688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the updated libc, UNIX stack overflow handling in libstd can now use the common `si_addr` accessor function, rather than attempting to use a field from that name in `siginfo_t`. This simplifies the collection of the fault address, particularly on platforms where that data resides within a union in `siginfo_t`.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 33fd73f has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup=never |
|
⌛ Testing commit 33fd73f with merge 09c5cdd5809ae6ff82074d6059d780bbae5c696b... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Hmm, that failure looks like an artifact. Maybe retry? |
|
Error the same, as in #95737. Error message introduced in #95469, so @ChrisDenton |
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (846993e): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
|
@ChrisDenton the CI issue seems to be resolved though |
|
The failures are intermittent. Sometimes the test passes, sometimes it doesn't (it depends on whether the reads/writes complete synchronously or not). |
|
yeh that's fair i meant it's not blocking the CI so doesn't have to be reverted in a hurry |
bors
added a commit
to rust-lang/libc
that referenced
this pull request
Apr 9, 2022
Disable broken CI jobs These are temporarily removed until someone comes to fix them. The semver jobs have been broken for over a year now, but are ignored by bors. Now we just disable them completely since they cause confusion when reading the build logs. The uclibc targets were recently broken by rust-lang/rust#95688. They are missing a `si_addr()` function on `struct siginfo`.
bors
added a commit
to rust-lang/libc
that referenced
this pull request
Apr 10, 2022
Disable broken CI jobs These are temporarily removed until someone comes to fix them. The semver jobs have been broken for over a year now, but are ignored by bors. Now we just disable them completely since they cause confusion when reading the build logs. The uclibc targets were recently broken by rust-lang/rust#95688. They are missing a `si_addr()` function on `struct siginfo`.
This was referenced Apr 10, 2022
bors
added a commit
to rust-lang/libc
that referenced
this pull request
Apr 10, 2022
Disable broken CI jobs These are temporarily removed until someone comes to fix them. The semver jobs have been broken for over a year now, but are ignored by bors. Now we just disable them completely since they cause confusion when reading the build logs. The uclibc targets were recently broken by rust-lang/rust#95688. They are missing a `si_addr()` function on `struct siginfo`.
bors
added a commit
to rust-lang/libc
that referenced
this pull request
Apr 10, 2022
Disable broken CI jobs These are temporarily removed until someone comes to fix them. The semver jobs have been broken for over a year now, but are ignored by bors. Now we just disable them completely since they cause confusion when reading the build logs. The uclibc targets were recently broken by rust-lang/rust#95688. They are missing a `si_addr()` function on `struct siginfo`.
|
@ChrisDenton any plans on reverting? seeing this issue too frequently in the last few days that's annoying especially in rollups |
|
I had my hopes on #95841 but it's not been reviewed yet. I guess it being a weekend doesn't help. |
bors
added a commit
to rust-lang/libc
that referenced
this pull request
Apr 12, 2022
Add siginfo accessors for uclibc With rust-lang/rust#95688 switching to the libc-provided `si_addr()` accessor on `siginfo_t`, it became apparent that the uclibc target was lacking that implementation (see rust-lang/rust#95866). It would be nice to provide the same accessor in uclibc as the other UNIX-y platforms. CC: `@asomers` `@name1e5s` `@skrap` - If you have a testing env for this, could you try it out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the updated libc, UNIX stack overflow handling in libstd can now
use the common
si_addraccessor function, rather than attempting touse a field from that name in
siginfo_t. This simplifies thecollection of the fault address, particularly on platforms where that
data resides within a union in
siginfo_t.