Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Increase a pipe's buffer capacity to 64kb #95782

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Windows: Increase a pipe's buffer capacity to 64kb #95782

merged 1 commit into from
Apr 8, 2022

Conversation

ChrisDenton
Copy link
Member

This brings it inline with typical Linux defaults: https://www.man7.org/linux/man-pages/man7/pipe.7.html

Since Linux 2.6.11, the pipe capacity is 16 pages (i.e., 65,536 bytes in a system with a page size of 4096 bytes).

This may also help with #45572 and #95759 but does not fix either issue. It simply makes them much less likely to be encountered.

@rust-highfive
Copy link
Collaborator

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 7, 2022
thomcc
thomcc approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!

@thomcc
Copy link
Member

thomcc commented Apr 8, 2022

Sorry, forgot I had to do this.
@bors r+

@bors
Copy link
Contributor

bors commented Apr 8, 2022

📌 Commit 6a4b444 has been approved by thomcc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 8, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 8, 2022
@bors
Auto merge of rust-lang#95798 - Dylan-DPC:rollup-51hx1wl, r=Dylan-DPC
e4f5b15 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#95102 (Add known-bug for rust-lang#95034)
 - rust-lang#95579 (Add `<[[T; N]]>::flatten{_mut}`)
 - rust-lang#95634 (Mailmap update)
 - rust-lang#95705 (Promote x86_64-unknown-none target to Tier 2 and distribute build artifacts)
 - rust-lang#95761 (Kickstart the inner usage of `macro_metavar_expr`)
 - rust-lang#95782 (Windows: Increase a pipe's buffer capacity to 64kb)
 - rust-lang#95791 (hide an #[allow] directive from the Arc::new_cyclic doc example)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fdfdb33 into rust-lang:master Apr 8, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 8, 2022
@ChrisDenton ChrisDenton deleted the pipe-buffer-size branch April 8, 2022 13:24
@ChrisDenton ChrisDenton mentioned this pull request Apr 8, 2022
Open
@FreezyLemon FreezyLemon mentioned this pull request Jul 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcc thomcc thomcc approved these changes

Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ChrisDenton @rust-highfive @thomcc @bors @rustbot