Allow dynamic linking on ios. #95847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
|
r? @wesleywiser since it sounds like you've dug into this in the past and maybe can more quickly page back into cache |
wesleywiser
added
the
I-compiler-nominated
|
Nominating for discussion in this week's compiler team meeting. |
|
We discussed this at today's compiler team meeting and the general consensus was that we felt this will need to go through the Major Change Proposal process. One thing in particular to highlight in the proposal is what the anticipated changes will need to be on downstream crates to resolve the breakage that occurred last time we changed this. |
apiraino
removed
the
I-compiler-nominated
wesleywiser
added
S-waiting-on-author
|
sorry, have way to much stuff to do at the moment. will close it for now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dynamic linking is supported on ios. this was enabled previously but then reverted due to backwards compatibility concerns. now that
cargo rustchas a--crate-typeflag these concerns aren't warrented any more, with new evidence presented in [0]. Given this new evidence I'm reenabling dynamic linking on ios.