Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #[rustc_deprecated] #95960

Merged
merged 6 commits into from
May 9, 2022
Merged

Remove #[rustc_deprecated] #95960

merged 6 commits into from
May 9, 2022

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Apr 12, 2022

This removes #[rustc_deprecated] and introduces diagnostics to help users to the right direction (that being #[deprecated]). All uses of #[rustc_deprecated] have been converted. CI is expected to fail initially; this requires #95958, which includes converting stdarch.

I plan on following up in a short while (maybe a bootstrap cycle?) removing the diagnostics, as they're only intended to be short-term.

@rust-highfive
Copy link
Collaborator

Thank you for submitting a new PR for the library teams! If this PR contains a stabilization of a library feature that has not already completed FCP in its tracking issue, introduces new or changes existing unstable library APIs, or changes our public documentation in ways that create new stability guarantees then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 12, 2022
@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2022
@jhpratt

This comment was marked as resolved.

Sign in to view
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) and removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 12, 2022
@jhpratt
Copy link
Member Author

jhpratt commented Apr 12, 2022

(that's the failure I was expecting)

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jhpratt jhpratt force-pushed the remove-rustc_deprecated branch 2 times, most recently from fc4e862 to f81e20e Compare April 14, 2022 04:38
@jhpratt
Copy link
Member Author

jhpratt commented Apr 14, 2022

CI is green, but I'd still like to make a few more changes before this should be merged.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
This was referenced Apr 14, 2022
Merged
Merged
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jhpratt
Add note to E0550
dac487a 
With the change to built-in duplicate checking, E0550 is no longer
emitted.
@jhpratt
Copy link
Member Author

jhpratt commented Apr 15, 2022

After playing whack-a-mole with tests and running into a spurious error, CI is once again green. I'm happy with where this is now. Ready for review @joshtriplett!

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 15, 2022
@wesleywiser
Copy link
Member

r? rust-lang/compiler

compiler-errors
compiler-errors approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 9, 2022

📌 Commit dac487a has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2022
@bors
Copy link
Contributor

bors commented May 9, 2022

⌛ Testing commit dac487a with merge 8a2fe75...

@bors
Copy link
Contributor

bors commented May 9, 2022

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 8a2fe75 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 9, 2022
@bors bors merged commit 8a2fe75 into rust-lang:master May 9, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 9, 2022
@bors bors mentioned this pull request May 9, 2022
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8a2fe75): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

bors added a commit to rust-lang/rust-analyzer that referenced this pull request May 9, 2022
@bors
Auto merge of #11983 - jhpratt:remove-rustc_deprecated, r=lnicola
3d2d209 
Remove handling of `#[rustc_deprecated]`

This should be merged along with rust-lang/rust#95960.

Because the attribute still exists in rustc, I've left the definition here. With that said, any use of it is an error, so I've removed any handling of `#[rustc_deprecated]`.
@jhpratt jhpratt deleted the remove-rustc_deprecated branch May 9, 2022 13:07
@jhpratt jhpratt mentioned this pull request Jun 14, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 15, 2022
@Dylan-DPC
Rollup merge of rust-lang#98115 - jhpratt:remove-rustc_deprecated, r=…
2b403ff 
…compiler-errors

Remove `rustc_deprecated` diagnostics

Follow-up on rust-lang#95960. The diagnostics will remain until the next bootstrap, at which point people will have had six weeks to adjust.

`@rustbot` label +A-diagnostics

r? `@compiler-errors`
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 15, 2022
@JohnTitor
Rollup merge of rust-lang#98115 - jhpratt:remove-rustc_deprecated, r=…
b1e5472 
…compiler-errors

Remove `rustc_deprecated` diagnostics

Follow-up on rust-lang#95960. The diagnostics will remain until the next bootstrap, at which point people will have had six weeks to adjust.

``@rustbot`` label +A-diagnostics

r? ``@compiler-errors``
est31 added a commit to est31/std-dev-guide that referenced this pull request Aug 23, 2022
@est31
rustc_deprecated got removed, now only deprecated is used
eca4207 
rust-lang/rust#95960
est31 added a commit to est31/std-dev-guide that referenced this pull request Aug 23, 2022
@est31
rustc_deprecated got removed, now only deprecated is used
125fd7c 
See rust-lang/rust#95960
@est31 est31 mentioned this pull request Aug 23, 2022
Merged
@dtolnay dtolnay mentioned this pull request Nov 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
9 participants
@jhpratt @rust-highfive @rust-log-analyzer @wesleywiser @compiler-errors @bors @rust-timer @joshtriplett @rustbot