Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: fix duplicate blanket impls #96095

Conversation

notriddle
Copy link
Contributor

Fixes #96036

This is a different approach than #96091, an approach that should have less
performance impact.

Fixes rust-lang#96036

This is a different approach than rust-lang#96091, an approach that should have less
performance impact.
@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 15, 2022
@rust-highfive
Copy link
Collaborator

r? @CraftSpider

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2022
@notriddle
Copy link
Contributor Author

r? @GuillaumeGomez

@notriddle notriddle marked this pull request as draft April 15, 2022 23:51
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
configure: rust.debug-assertions := True
configure: rust.overflow-checks := True
configure: llvm.assertions      := True
configure: dist.missing-tools   := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure: 
---
skip untracked path src/doc/rust-by-example/ during rustfmt invocations
skip untracked path src/llvm-project/ during rustfmt invocations
Diff in /checkout/src/librustdoc/formats/cache.rs at line 476:
             } else {
                 let trait_did = impl_item.trait_did().expect("no trait did");
                 if let ItemId::Blanket { for_, .. } = &impl_item.impl_item.def_id {
-                    dids = dids
-                        .into_iter()
-                        .filter(|did| did == for_)
-                        .collect();
+                    dids = dids.into_iter().filter(|did| did == for_).collect();
                 }
                 self.cache.orphan_trait_impls.push((trait_did, dids, impl_item));
             }
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustfmt" "--config-path" "/checkout" "--edition" "2021" "--unstable-features" "--skip-children" "--check" "/checkout/src/bootstrap/toolstate.rs" "/checkout/src/bootstrap/cache.rs" "/checkout/src/librustdoc/formats/item_type.rs" "/checkout/src/librustdoc/formats/mod.rs" "/checkout/library/rustc-std-workspace-alloc/lib.rs" "/checkout/compiler/rustc_fs_util/src/lib.rs" "/checkout/compiler/rustc_lint/src/non_fmt_panic.rs" "/checkout/src/librustdoc/formats/cache.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.

@notriddle notriddle closed this Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc: Many times the same From<!> for T impl for the ! type
6 participants