Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve bootstrap tests #96303

Merged
merged 3 commits into from
Apr 24, 2022
Merged

Improve bootstrap tests #96303

merged 3 commits into from
Apr 24, 2022

Commits on Apr 22, 2022

  1. Don't checkout submodules in bootstrap tests 

    This doesn't cause any tests to fail, and can greatly speed them up.
    @jyn514
    jyn514 committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    8b94fbe View commit details
    Browse the repository at this point in the history

  2. Add a test for --exclude test::XXX 

    I didn't know that the `test::` syntax was valid before, and it doesn't
seem to be documented anywhere. Add a test so it doesn't regress accidentally,
and as executable documentation.
    @jyn514
    jyn514 committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    7a4a66d View commit details
    Browse the repository at this point in the history

  3. Use run_build helper consistently across most bootstrap tests 

    This is not super important to do, but the consistency is nice.

I didn't change any tests that call `configure("dist")` and then override the subcommand - doing
that at all is pretty sketchy, but I don't want to mess with it while already doing a refactor.
    @jyn514
    jyn514 committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    3bac5c0 View commit details
    Browse the repository at this point in the history