Eliminate duplication code of building panic langcall during codegen #96474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @fee1-dead (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? rust-lang/compiler |
lcnr
reviewed
Apr 28, 2022
| li: LangItem, | ||
| ) -> (Bx::FnAbiOfResult, Bx::Value) { | ||
| let tcx = bx.tcx(); | ||
| let def_id = tcx.lang_items().require(li).unwrap_or_else(|s| { |
There was a problem hiding this comment.
use tcx.require_lang_item instead here.
apart from that r=me
There was a problem hiding this comment.
Yea, that makes sense
|
@bors r+ rollup |
|
📌 Commit cf00142 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 29, 2022
Eliminate duplication code of building panic langcall during codegen From the FIXME in the `codegen_panic_intrinsic` func.
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (1c8966e): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the FIXME in the
codegen_panic_intrinsicfunc.