rustdoc: Create an attribute version of --extern-html-root-url
#96533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #97239) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
extern-html-root-url
branch
from
91fe5fe to
cd2a21a
Compare
|
Fixed merge conflict. |
|
☔ The latest upstream changes (presumably #98242) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@GuillaumeGomez @rustbot label: +S-inactive |
rustbot
added
the
S-inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential first step for a change of behaviour for
--html-root-url. Currently, unless you use--extern-html-root-takes-precedence, if you have set--html-root-url, it'll always skip the content of--extern-html-root-url. I'd prefer if it did that only in case there is no entry for this crate, which would make more sense I think.Anyway, this PR is "only" about allowing to write:
#![doc(extern_html_root_url(std = "https://doc.rust-lang.org/nightly"))]I felt the need for it because of #96519.
So what do you think?
cc @rust-lang/rustdoc
r? rust-lang/rustdoc