Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tracing for all queries #96697

Merged
merged 1 commit into from
May 5, 2022
Merged

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented May 4, 2022

This allows you to log everything within a specific query, e.g.

env RUSTC_LOG=[mir_borrowck]

dumping all borrowck queries may be a bit verbose, so you can also restrict it to just an item of your choice:

env RUSTC_LOG=[mir_borrowck{key=\.\*name_of_item\.\*}]

the regex .* in the key name are because the key is a debug printed DefId, so you'd get all kinds of things like hashes in there. The tracing logs will show you the key, so you can restrict it further if you want.

@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 4, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 4, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented May 4, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 4, 2022
@bors
Copy link
Contributor

bors commented May 4, 2022

⌛ Trying commit b4a8846fc3f07345f46068b75c34338528defb2d with merge 1d59938c45561174f235b85ff117546120d6fd4f...

@oli-obk oli-obk changed the title Enable tracing for all queryies Enable tracing for all queries May 4, 2022
@bors
Copy link
Contributor

bors commented May 4, 2022

☀️ Try build successful - checks-actions
Build commit: 1d59938c45561174f235b85ff117546120d6fd4f (1d59938c45561174f235b85ff117546120d6fd4f)

@rust-timer
Copy link
Collaborator

Queued 1d59938c45561174f235b85ff117546120d6fd4f with parent 21d613b, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1d59938c45561174f235b85ff117546120d6fd4f): comparison url.

Summary:

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regressions found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 0 8 0 0 0
mean2 N/A 0.4% N/A N/A N/A
max N/A 0.6% N/A N/A N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 4, 2022
@michaelwoerister
Copy link
Member

michaelwoerister commented May 4, 2022

That's pretty neat! There's a small performance regression in some secondary benchmarks. Not sure if we should take those seriously? Does #[instrument] do anything when debug-assertions are disabled?

@oli-obk
Copy link
Contributor Author

oli-obk commented May 4, 2022

That's pretty neat! There's a small performance regression in some secondary benchmarks. Not sure if we should take those seriously? Does #[instrument] do anything when debug-assertions are disabled?

no, it's statically compiled out, I was just worried I screwed some of that up, thus the perf run

@michaelwoerister
Copy link
Member

Feel free to r=me.

@oli-obk
Copy link
Contributor Author

oli-obk commented May 4, 2022

@bors r=michaelwoerister

@bors
Copy link
Contributor

bors commented May 4, 2022

📌 Commit 0d5a738 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented May 4, 2022

@bors rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request May 5, 2022
Rollup of 7 pull requests

Successful merges:

 - rust-lang#96603 (Enable full revision in const generics ui tests)
 - rust-lang#96616 (Relax memory ordering used in `min_stack`)
 - rust-lang#96619 (Relax memory ordering used in SameMutexCheck)
 - rust-lang#96628 (Stabilize `bool::then_some`)
 - rust-lang#96658 (Move callback to the () => {} syntax.)
 - rust-lang#96677 (Add more tests for label-break-value)
 - rust-lang#96697 (Enable tracing for all queries)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ade1232 into rust-lang:master May 5, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants