Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the test check-pass not to produce a JSON file #96777

Merged
merged 1 commit into from
May 8, 2022

Conversation

JohnTitor
Copy link
Member

run-pass produces a JSON file when enabling save analysis.
The original ICE happened on cargo check, moreover without the generic_const_exprs feature, so check-pass should be enough.

`run-pass` produces a JSON file when enabling save analysis.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 6, 2022
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 7, 2022

📌 Commit 038fb67 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 7, 2022
…askrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#96336 (Link to correct `as_mut` in docs for `pointer::as_ref`)
 - rust-lang#96586 (Add aliases for std::fs::canonicalize)
 - rust-lang#96667 (Add regression test)
 - rust-lang#96671 (Remove hard links from `env::current_exe` security example)
 - rust-lang#96726 (Add regression and bug tests)
 - rust-lang#96756 (Enable compiler-docs by default for `compiler`, `codegen`, and `tools` profiles)
 - rust-lang#96757 (Don't constantly rebuild clippy on `x test src/tools/clippy`.)
 - rust-lang#96769 (Remove `adx_target_feature` feature from active features list)
 - rust-lang#96777 (Make the test `check-pass` not to produce a JSON file)
 - rust-lang#96822 (Enforce quote rule for JS source code)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d6c9254 into rust-lang:master May 8, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 8, 2022
@JohnTitor JohnTitor deleted the do-not-run-pass-save-analysis branch May 8, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants