Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint single-use lifetimes during AST resolution #96833

Merged
merged 3 commits into from
May 20, 2022
Merged

Lint single-use lifetimes during AST resolution #96833

merged 3 commits into from
May 20, 2022

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented May 8, 2022 •
edited
Loading

This PR rewrites single_use_lifetime and unused_lifetime lints to be based on the AST.
We have more information at our disposal, so we can reduce the amount of false positives.

Remaining false positive: single-use lifetimes in argument-position impl-trait.
I'm waiting for #96529 to be fixed to have a clean and proper solution here.

Closes #54079
Closes #55057
Closes #55058
Closes #60554
Closes #69952

r? @petrochenkov

@cjgillot cjgillot added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label May 8, 2022
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 8, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 8, 2022
@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 8, 2022
@cjgillot cjgillot force-pushed the ast-lifetimes-single branch from c4ce5f5 to 64c8663 Compare May 10, 2022 19:30
@cjgillot cjgillot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels May 10, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

This comment was marked as resolved.

Sign in to view
@cjgillot cjgillot force-pushed the ast-lifetimes-single branch from b4cbf5e to f629d7d Compare May 15, 2022 15:41
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@cjgillot cjgillot force-pushed the ast-lifetimes-single branch from 4799029 to 69b9166 Compare May 15, 2022 18:16
petrochenkov
petrochenkov reviewed May 19, 2022
View reviewed changes
compiler/rustc_lint/src/context.rs Outdated Show resolved Hide resolved
src/test/ui/single-use-lifetime/one-use-in-struct.rs Show resolved Hide resolved
src/test/ui/async-await/unused-lifetime.rs Outdated Show resolved Hide resolved
compiler/rustc_lint/src/levels.rs Show resolved Hide resolved
compiler/rustc_resolve/src/late.rs Outdated Show resolved Hide resolved
compiler/rustc_resolve/src/late.rs Outdated Show resolved Hide resolved
compiler/rustc_parse/src/parser/ty.rs Outdated Show resolved Hide resolved
compiler/rustc_parse/src/parser/ty.rs Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 19, 2022
@petrochenkov
Copy link
Contributor

r=me after squashing review commits into main commits.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2022
@cjgillot cjgillot force-pushed the ast-lifetimes-single branch from a7e8836 to 563916d Compare May 20, 2022 11:39
@cjgillot
Copy link
Contributor Author

@bors r=petrochenkov

@bors
Copy link
Contributor

bors commented May 20, 2022

📌 Commit 563916d has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 20, 2022
@bors
Copy link
Contributor

bors commented May 20, 2022

⌛ Testing commit 563916d with merge b5caa5a...

@bors
Copy link
Contributor

bors commented May 20, 2022

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing b5caa5a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 20, 2022
@bors bors merged commit b5caa5a into rust-lang:master May 20, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 20, 2022
This was referenced May 20, 2022
Merged
Merged
Merged
Closed
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b5caa5a): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 0 0 0 1 0
mean2 N/A N/A N/A -0.6% N/A
max N/A N/A N/A -0.6% N/A

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: 😿 relevant regression found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 1 1 2 0 3
mean2 2.4% 3.6% -2.4% N/A -0.8%
max 2.4% 3.6% -2.5% N/A -2.5%

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: mixed results
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 1 2 2 2 3
mean2 3.4% 1.8% -2.2% -1.9% -0.3%
max 3.4% 2.3% -2.6% -2.7% 3.4%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes ↩ ↩2 ↩3

  2. the arithmetic mean of the percent change ↩ ↩2 ↩3

@cjgillot cjgillot deleted the ast-lifetimes-single branch May 22, 2022 08:56
@est31 est31 mentioned this pull request May 29, 2022
Open
2 tasks
@oskgo oskgo mentioned this pull request Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
7 participants
@cjgillot @rust-log-analyzer @bors @petrochenkov @rust-timer @rust-highfive @rustbot