diagnostics: port more diagnostics to derive + support for () fields
#96853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
|
cc @Mark-Simulacrum for compiletest changes |
This comment was marked as resolved.
This comment was marked as resolved.
davidtwco
force-pushed
the
diagnostic-translation-unit-and-more-porting
branch
from
4664552
to
ecde2d9
Compare
oli-obk
requested changes
May 9, 2022
Comment on lines
+248
to
+254
| #[help] | ||
| pub is_nightly_build: Option<()>, |
There was a problem hiding this comment.
I'm wondering if it could be useful to require the field name in the fluent file for spanless helps. Or generally for optional fields. It could be surprising to see some of them if you look at the entire fluent spec for an error, because you'd see all fields and they'd look "equal".
But considering I have zero fluent experience, that's just me guessing from the files.
There was a problem hiding this comment.
Maybe, I don't think it's worth changing this right now but it should be fairly easy to change down the line if we want to.
klensy
reviewed
May 9, 2022
klensy
reviewed
May 9, 2022
oli-obk
added
S-waiting-on-author
Type attributes could previously be used to support spanless subdiagnostics but these couldn't easily be made optional in the same way that spanned subdiagnostics could by using a field attribute on a field with an `Option<Span>` type. Spanless subdiagnostics can now be specified on fields with `()` type or `Option<()>` type. Signed-off-by: David Wood <david.wood@huawei.com>
Using new support for spanless subdiagnostics from `()` fields in the diagnostic derive, simplify the "explicit generic args with impl trait" diagnostic's struct. Signed-off-by: David Wood <david.wood@huawei.com>
When testing macros from `rustc_macros` in `ui-fulldeps` tests, sometimes paths from the compiler source tree can be shown in error messages - these need to be normalized. Signed-off-by: David Wood <david.wood@huawei.com>
Manual implementors of translatable diagnostics will need to call `set_arg`, not just the derive, so make this function a bit more ergonomic by taking `IntoDiagnosticArg` rather than `DiagnosticArgValue`. Signed-off-by: David Wood <david.wood@huawei.com>
Port the "the type parameter `T` must be explicitly specified" diagnostic to using a diagnostic struct. Signed-off-by: David Wood <david.wood@huawei.com>
Port the "manual implementations of `X` are experimental" diagnostic to use the diagnostic derive. Signed-off-by: David Wood <david.wood@huawei.com>
Port "could not resolve substs on overridden impl" diagnostic to use the diagnostic derive. Signed-off-by: David Wood <david.wood@huawei.com>
davidtwco
force-pushed
the
diagnostic-translation-unit-and-more-porting
branch
from
ecde2d9
to
4758247
Compare
davidtwco
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 4758247 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (18bd2dd): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
compiler-errors
added
the
A-translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
help/note) can be applied via attributes to fields of type()(currently spanless subdiagnostics are applied via attributes on the diagnostic struct itself). A consequence of this is thatOption<()>fields can be used to represent optional spanless subdiagnostics, which are sometimes useful (e.g. for ahelpthat should only show on nightly builds).Vecfields #96760) using support forOption<()>spanless subdiagnostics.DiagnosticBuilder::set_arg, used to provide context for Fluent messages, so that it takes anything that implementsIntoDiagnosticArg, rather thanDiagnosticArgValue- this improves the ergonomics of manual implementations ofSessionDiagnosticwhich are translatable.Tmust be explicitly specified", "manual implementations ofXare experimental", "could not resolve substs on overridden impl" diagnostics to diagnostic structs.rustc_macrosinui-fulldepstests, sometimes paths from the compiler source tree can be shown in error messages - these need to be normalized incompiletest.r? @oli-obk
cc @pvdrz