-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbid lifetime bounds in nested opaque types in binders #96970
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
cc @cjgillot on the HIR lowering changes. I think it's fine to only do this for named lifetimes, as all others are forbidden anyway ( |
@bors try |
⌛ Trying commit 1b73e54 with merge 3f7b27fe41ccd116a4c0829bd9a14b65bada4578... |
☀️ Try build successful - checks-actions |
@craterbot check |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
@oli-obk I don't understand your comment about anonymous lifetimes.
To be on the safe side, I'd rather have named and anonymous lifetimes treated the same way. The "other errors" are feature gates for impl-trait in |
…ppear in practice
r=me if you're still in search for a reviewer, I am satisfied with the most recent changes after the second commit |
@bors r=compiler-errors p=1 |
📌 Commit 193a16b has been approved by |
This doesn't cherry pick cleanly onto beta, so I'm holding off on a backport until someone can prepare that -- the diff doesn't look trivial to me, though I haven't looked super closely. If necessary I'll probably devote a few hours on the weekend or Monday to push it through. |
⌛ Testing commit 193a16b with merge 71e302eebe4f7c63d76f39c5b03453e12b6c3db0... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
NLL tests need to be blessed, but @pnkfelix has pointed out an interesting side effect of this PR, being:
Current nightly accepts the following code, for example: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=f25115b4ae04c819e56781bf952b766f @bors r- until that issue is settled |
Forbid nested opaque types to reference HRTB from opaque types. Avoids rust-lang#96194 Alternative to rust-lang#96970 r? `@oli-obk`
Closing as @cjgillot wrote an actual fix instead of overzealous patch that this PR was |
De-accepting from beta backport. |
…Simulacrum Bump to 1.63 r? `@Mark-Simulacrum` Posting this now, but will only approve later today / early tomorrow to give a little more time for not-yet-approved PRs to land on master (e.g., rust-lang#96970).
🎉 Experiment
|
avoids #96194
Not closing the issue until we have this behind a feature gate and with a corresponding tracking issue.
Since this change is supposed to get backported to beta, I don't want to add a gate and more logic in this PR. Instead, it will happen on a follow up PR solely on nightly.