Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unused_macro_rules in path tests (backport to beta) #97141

Conversation

raoulstrackx
Copy link
Contributor

PR #96150 adds a new lint to warn about unused macro rules (arms/matchers). This causes errors in library/std/src/path/tests.rs on the x86_64-fortanix-unknown-sgx platform. This PR fixes compilation errors on that platform by allowing unused macro rules.

This PR is a backport from #97009

@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 18, 2022
@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2022
@raoulstrackx
Copy link
Contributor Author

Can this have a review please?

@raoulstrackx
Copy link
Contributor Author

Pretty please? :)

@est31
Copy link
Member

est31 commented Jun 7, 2022

This PR doesn't need a beta backport, due to #97032 having been beta backported in #97631. Eventually the plan is to re-enable the lint, so having an allow in master is good for future changes, but that won't affect the code in beta.

@raoulstrackx
Copy link
Contributor Author

raoulstrackx commented Jun 22, 2022

No longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants