Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move processing of source_scope_data into MutVisitor's impl of Integrator when inline #97142

Merged
merged 1 commit into from
May 20, 2022
Merged

move processing of source_scope_data into MutVisitor's impl of Integrator when inline #97142

merged 1 commit into from
May 20, 2022

Conversation

SparrowLii
Copy link
Member

This PR fixes the FIXME in the inline mir-opt which moves processing of source_scope_data into MutVisitor's impl of Integrator when inline

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 18, 2022
@rust-highfive
Copy link
Collaborator

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2022
@tmiasko
Copy link
Contributor

tmiasko commented May 18, 2022

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented May 18, 2022

📌 Commit 420f9a3 has been approved by tmiasko

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2022
@bors
Copy link
Contributor

bors commented May 19, 2022

⌛ Testing commit 420f9a3 with merge 87f12a90bbf92492c7ebb5d83f931f10a6ba42fe...

@rust-log-analyzer
Copy link
Collaborator

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
---- [ui] src/test/ui/binding/match-pattern-lit.rs stdout ----

error: test run failed!
status: exit status: 101
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/remote-test-client" "run" "0" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/binding/match-pattern-lit/a"
--- stdout -------------------------------
uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/binding/match-pattern-lit/a", waiting for result
--- stderr -------------------------------
--- stderr -------------------------------
thread 'main' panicked at 'client.read_exact(&mut header) failed with Connection reset by peer (os error 104)', src/tools/remote-test-client/src/main.rs:310:9
------------------------------------------

@bors
Copy link
Contributor

bors commented May 19, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 19, 2022
@tmiasko
Copy link
Contributor

tmiasko commented May 19, 2022

@bors retry "Connection reset by peer"

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request May 19, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 19, 2022
@bors
Auto merge of rust-lang#97180 - Dylan-DPC:rollup-aa5j2yw, r=Dylan-DPC
a09d36d 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#96539 (Add release notes for 1.61.0)
 - rust-lang#97142 (move processing of `source_scope_data` into `MutVisitor`'s impl of `Integrator` when inline)
 - rust-lang#97155 (Fix doc typo)
 - rust-lang#97169 (Improve `u32 as char` cast diagnostic)
 - rust-lang#97170 (Remove unnecessay .report() on ExitCode)
 - rust-lang#97171 (Add regression test for rust-lang#88119)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 362f598 into rust-lang:master May 20, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
7 participants
@SparrowLii @rust-highfive @tmiasko @bors @rust-log-analyzer @jackh726 @rustbot