Remove feature: crate visibility modifier
#97254
Conversation
rustbot
added
the
T-compiler
|
Some changes occurred in src/tools/rustfmt. cc @rust-lang/rustfmt Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
CI is green. |
|
@bors r+ |
|
📌 Commit 7b987e3 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 7b987e3 with merge fce5cb75b281d232807fdb057b214d47a188e3eb... |
|
@bors retry aarch64-gnu seems stuck It's been running for over 2.5 hours when normally it takes <50 mins. |
Rollup of 5 pull requests Successful merges: - rust-lang#97087 (Clarify slice and Vec iteration order) - rust-lang#97254 (Remove feature: `crate` visibility modifier) - rust-lang#97271 (Add regression test for rust-lang#91949) - rust-lang#97294 (std::time : fix variable name in the doc) - rust-lang#97303 (Fix some typos in arg checking algorithm) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Remove feature: `crate` visibility modifier FCP completed in rust-lang#53120.
|
@jhpratt Just a note: The feature doesn't end up even saying it is removed if you have used the For example, in a crate I had that used it, all it gave was this, and no other errors: error: expected one of `!` or `::`, found keyword `struct`
--> src\main.rs:68:11
|
68 | crate struct Features(u8);
| ^^^^^^ expected one of `!` or `::` |
|
Eh, I don't see an issue with that to be honest. That's what happens when things are removed. |
FCP completed in #53120.